Skip to content

feat: Discourage assert(Not)Empty if "empty" usage is disallowed - #325

Open
mitelg wants to merge 3 commits into
phpstan:2.0.xfrom
mitelg:feat/dissallow-assert-empty
Open

mitelg wants to merge 3 commits into
phpstan:2.0.xfrom
mitelg:feat/dissallow-assert-empty

Conversation

@mitelg

@mitelg mitelg commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

fixes: #270

Hey,

first attempt to fix the linked issue. I used Codex for that and I hope it did the job correct 😁 Tests are looking fine for me.

Happy to get some feedback 🤝

Best regards 👋

@mitelg
mitelg force-pushed the feat/dissallow-assert-empty branch 2 times, most recently from 410764b to 927cf58 Compare August 21, 2026 09:45
Comment thread rules.neon Outdated
@mitelg
mitelg force-pushed the feat/dissallow-assert-empty branch 2 times, most recently from 3ac6163 to 589b9ed Compare September 10, 2026 14:31
@mitelg
mitelg requested a review from staabm September 10, 2026 14:56
Comment thread rules.neon Outdated
Comment thread rules.neon
Comment thread src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php Outdated
@mitelg
mitelg force-pushed the feat/dissallow-assert-empty branch from 589b9ed to 7dd505d Compare September 21, 2026 07:29
@mitelg
mitelg force-pushed the feat/dissallow-assert-empty branch from 7dd505d to bde80a9 Compare September 21, 2026 07:31
@mitelg
mitelg force-pushed the feat/dissallow-assert-empty branch from bde80a9 to 8425e53 Compare September 21, 2026 07:54
@mitelg
mitelg force-pushed the feat/dissallow-assert-empty branch from 8425e53 to 11b89f7 Compare September 21, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disallow assertEmpty with strict rule disallowedEmpty set

3 participants