Skip to content

Fix nette build #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 1 commit into from
Sep 21, 2026
+15 −11
Merged

Fix nette build #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/Rule/Nette/RethrowExceptionRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,7 @@ public function getNodeType(): string

public function processNode(Node $node, Scope $scope): array
{
$hasGeneralCatch = false;
foreach ($node->catches as $catch) {
foreach ($catch->types as $type) {
$typeClass = (string) $type;
if ($typeClass === 'Exception' || $typeClass === Throwable::class) {
$hasGeneralCatch = true;
break 2;
}
}
}
if (!$hasGeneralCatch) {
if (!$this->hasGeneralCatch($node)) {
return [];
}

Expand Down Expand Up @@ -92,6 +82,20 @@ public function processNode(Node $node, Scope $scope): array
return $messages;
}

private function hasGeneralCatch(TryCatch $node): bool
{
foreach ($node->catches as $catch) {
foreach ($catch->types as $type) {
$typeClass = (string) $type;
if ($typeClass === 'Exception' || $typeClass === Throwable::class) {
return true;
}
}
}

return false;
}

/**
* @param Node|Node[]|scalar $node
* @return string[]
Expand Down
Loading