Conversation
getElementById() relies on the XML_ATTRIBUTE_ID flag, which dom_check_register_attribute_id() set only for HTML documents, leaving Dom\XMLDocument::getElementById() blind to ids assigned through setAttribute(), setAttributeNS() and setAttributeNode(). Drop the document-type restriction so modern XML documents register an un-namespaced id attribute; setIdAttribute(false) still unregisters and legacy DOMDocument is unchanged because every call site sits behind spec mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dom_check_register_attribute_id() sets XML_ATTRIBUTE_ID only when the document is XML_HTML_DOCUMENT_NODE, so Dom\XMLDocument::getElementById() returns null after setAttribute("id", ...) even though the id property registered fine. Dropping the document-type restriction lets modern XML documents register an un-namespaced id attribute, setIdAttribute(false) still unregisters, and legacy DOMDocument is unchanged because every helper call site sits behind spec mode. All three call sites were audited.