ext/standard: Fix Io\Poll timeouts longer than INT_MAX milliseconds - #23793
Merged
Merged
Conversation
php_poll_timespec_to_ms() cast seconds * 1000 to an int, so a wait() of more than about 24 days wrapped around: five years came out as 48ms on the poll backend. The value is capped now. epoll is only affected where it falls back to epoll_wait(), since epoll_pwait2() takes the timespec as is.
bukka
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also found while building an
Io\Polldriver for revolt/event-loop, unrelated to #23791.php_poll_timespec_to_ms()caststv_sec * 1000to anint, so a timeout of more than about 24 days wraps around andwait()returns almost at once:The value is capped at
INT_MAXnow. This hits thepolland WSAPoll backends, and epoll only where it falls back toepoll_wait(), sinceepoll_pwait2()takes the timespec as is.A timeout beyond 24 days still ends early, without any event, which is what the other users of that helper already assume. Waiting the whole duration would mean looping in each backend, tell me if you would rather have that.