ext/standard: Remove dead StreamPollHandle::getFileDescriptor() - #23792
Merged
Merged
Conversation
The method has no entry in the stub, so it is in no method table and cannot be called. The RFC does not list it either.
Contributor
Author
|
#23810 exports what an extension needs to accept an |
bukka
approved these changes
Sep 21, 2026
bukka
left a comment
bukka
left a comment
Member
There was a problem hiding this comment.
Ah yeah, this was a left over...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method has no entry in
io_poll.stub.php, so it is in no method table and calling it is aError: Call to undefined method StreamPollHandle::getFileDescriptor(). The RFC does not list it either.Happy to turn this around and declare it in the stub instead if exposing the fd is wanted.