Fix GH-23056: missing handler name in session write warning - #23059
Open
lazerg wants to merge 1 commit into
Open
Fix GH-23056: missing handler name in session write warning#23059lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
Contributor
Author
|
The WINDOWS_X64_ZTS failure (ext/standard/tests/mail) is unrelated to this change. It fails the same way on master's own tip (d7911aa), so it looks like the Windows mail test environment is currently broken independent of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the session data is unchanged, lazy write calls the update timestamp handler, and the warning names
ps_update_timestamp. That zval stays undefined for handlers that do not provide anupdateTimestamp()method, so the name came out empty. In that caseps_update_timestamp_user()calls the write handler instead, so the warning should name the write handler.This only shows on master because an empty session now encodes to an empty string rather than NULL, which lets the lazy write branch run where it previously did not.
Fixes GH-23056.