Skip to content

Allow the full php-soap/wsdl-reader 0.x range - #69

Merged
veewee merged 1 commit into
php-soap:mainfrom
veewee:feature/allow-wsdl-reader-0.33
Sep 3, 2026
Merged

Allow the full php-soap/wsdl-reader 0.x range#69
veewee merged 1 commit into
php-soap:mainfrom
veewee:feature/allow-wsdl-reader-0.33

Conversation

@veewee

@veewee veewee commented Sep 3, 2026

Copy link
Copy Markdown
Member

Unblocks webmozart/assert:^2 downstream, and avoids having to bump this constraint on every wsdl-reader 0.x release.

php-soap/wsdl-reader 0.33.0 widened its webmozart/assert constraint to ^1.11 || ^2.0, but php-soap/encoding pinned ^0.32 — which for a 0.x version means >=0.32 <0.33 — so consumers of phpro/soap-client still resolved to wsdl-reader 0.32 and were stuck on assert v1.

Constraint is now ~0.32 (>=0.32 <1.0), matching the style phpro/soap-client already uses.

Refs phpro/soap-client#613

Full test suite passes against wsdl-reader 0.33.0 (564 tests).

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 1f14cf45-a598-4605-9dec-b564963881cf

📥 Commits

Reviewing files that changed from the base of the PR and between 0edbbb5 and 73427f0.

📒 Files selected for processing (1)
  • composer.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Composer requirement for php-soap/wsdl-reader now accepts versions in either the ^0.32 or ^0.33 series.

Changes

Dependency Constraint Update

Layer / File(s) Summary
Widen Composer requirement
composer.json
The php-soap/wsdl-reader constraint now allows ^0.32 and ^0.33.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 73427

The dependency constraint now permits wsdl-reader 0.32 and 0.33 releases while retaining existing 0.32 compatibility. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the php-soap/wsdl-reader dependency change, but it overstates the scope because the constraint allows only ^0.32 and ^0.33, not the full 0.x range.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@veewee
veewee force-pushed the feature/allow-wsdl-reader-0.33 branch from 73427f0 to 7c1dfff Compare September 3, 2026 06:29
@veewee veewee changed the title Allow php-soap/wsdl-reader ^0.33 Allow the full php-soap/wsdl-reader 0.x range Sep 3, 2026
@veewee
veewee force-pushed the feature/allow-wsdl-reader-0.33 branch from 7c1dfff to 80136cd Compare September 3, 2026 06:32
@veewee
veewee force-pushed the feature/allow-wsdl-reader-0.33 branch from 80136cd to 7f7c9bd Compare September 3, 2026 06:33
@veewee
veewee merged commit e89a86e into php-soap:main Sep 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant