feat: group vs code extension updates in a single pull request - #1439
Open
Ron (rjaegers) wants to merge 1 commit into
Open
feat: group vs code extension updates in a single pull request#1439Ron (rjaegers) wants to merge 1 commit into
Ron (rjaegers) wants to merge 1 commit into
Conversation
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
❌MegaLinter analysis: Error
Detailed Issues❌ YAML / v8r - 1 error
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workflow/action changes introduce concrete failure-mode and runtime-compatibility risks (PR creation despite update failures, and Node engine requirements not being enforced) that should be addressed before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refactors the VS Code extension update automation to update all devcontainer configs in one run/PR, adds a cooldown window before adopting newly-published extension versions, and introduces a dedicated npm dependency set for the update action itself.
Changes:
- Consolidate VS Code extension updates across multiple devcontainer JSON files into a single workflow job and a single generated PR.
- Extend the
update-vscode-extensionscomposite action/script to accept multiple input files and enforce a version “cooldown” period. - Add Dependabot tracking for the composite action’s npm dependencies (introducing
package.json/package-lock.json).
File summaries
| File | Description |
|---|---|
| .github/workflows/update-dependencies.yml | Switch VS Code extension updates from matrix-per-file to a single consolidated update run/PR. |
| .github/dependabot.yml | Add a new npm update entry for the update-vscode-extensions action’s own dependencies. |
| .github/actions/update-vscode-extensions/update-vscode-extensions.sh | Add multi-file processing, cooldown logic, and per-file failure aggregation for extension updates. |
| .github/actions/update-vscode-extensions/action.yml | Replace global vsce install with npm ci and pass cooldown + local vsce path into the script. |
| .github/actions/update-vscode-extensions/package.json | Introduce pinned @vscode/vsce dev dependency for the composite action. |
| .github/actions/update-vscode-extensions/package-lock.json | Lock the composite action’s npm dependency tree for reproducible installs. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
25
to
29
| - run: | | ||
| sudo apt-get update | ||
| sudo apt-get install --no-install-recommends -y jq | ||
| sudo npm install -g @vscode/vsce | ||
| npm ci --prefix "${GITHUB_ACTION_PATH}" | ||
| shell: bash |
Comment on lines
+11
to
+12
| COOLDOWN_DAYS="${COOLDOWN_DAYS:-7}" | ||
| COOLDOWN_CUTOFF=$(date -u -d "-${COOLDOWN_DAYS} days" +"%Y-%m-%dT%H:%M:%S.000Z") |
| @@ -93,10 +101,13 @@ jobs: | |||
| - uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v8.1.1 | |||
| if: github.event_name != 'pull_request' | |||
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
✔️ Checklist