[FEATURE] Add test datasource connection button - #99
Open
adrianSepiol wants to merge 6 commits into
Open
Conversation
This was referenced Apr 7, 2026
adrianSepiol
marked this pull request as ready for review
April 7, 2026 09:30
adrianSepiol
marked this pull request as draft
July 27, 2026 12:51
adrianSepiol
force-pushed
the
add-test-connection-button
branch
3 times, most recently
from
July 27, 2026 14:19
3df35e7 to
6e06d51
Compare
adrianSepiol
marked this pull request as ready for review
July 27, 2026 14:23
adrianSepiol
force-pushed
the
add-test-connection-button
branch
from
July 27, 2026 14:31
6e06d51 to
bcda582
Compare
6 tasks
jgbernalp
reviewed
Jul 28, 2026
jgbernalp
reviewed
Jul 28, 2026
jgbernalp
reviewed
Jul 28, 2026
jgbernalp
reviewed
Jul 28, 2026
adrianSepiol
force-pushed
the
add-test-connection-button
branch
from
July 28, 2026 16:17
45bba07 to
3dc45bf
Compare
jgbernalp
reviewed
Aug 11, 2026
jgbernalp
reviewed
Aug 11, 2026
jgbernalp
reviewed
Aug 11, 2026
jgbernalp
reviewed
Aug 11, 2026
| const pluginSpec = spec.plugin.spec; | ||
|
|
||
| if (hasDirectUrl(pluginSpec)) { | ||
| await fetch(`${pluginSpec.directUrl.replace(/\/$/, '')}${normalizedPath}`, { |
Contributor
There was a problem hiding this comment.
We should check that the normalized path is not empty, otherwise we will be hitting the current UI which might lead to a successful connection check with an empty url
Contributor
Author
There was a problem hiding this comment.
Changed this code to URL, this way if this is not valid url we will get exception
jgbernalp
reviewed
Aug 11, 2026
adrianSepiol
force-pushed
the
add-test-connection-button
branch
from
August 12, 2026 13:31
3dc45bf to
45c6b62
Compare
jgbernalp
reviewed
Aug 18, 2026
jgbernalp
approved these changes
Aug 18, 2026
jgbernalp
left a comment
Contributor
There was a problem hiding this comment.
LGTM, sorry for the delay. As a follow up we can add the test button to the global datasources as well
Contributor
|
@adrianSepiol might need a rebase |
Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>
…ht to prevent duplicate calls Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>
…h check path Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>
…ceSpecEditor component Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>
…serting into allowedEndpoints endpointPattern Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>
adrianSepiol
force-pushed
the
add-test-connection-button
branch
from
August 18, 2026 10:44
45c6b62 to
afa4b63
Compare
…on validation Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>
adrianSepiol
force-pushed
the
add-test-connection-button
branch
from
August 18, 2026 12:09
afa4b63 to
724c245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Button for testing datasource connections
Related pull requests (in order):
Related issue:
perses/perses#1542
Description
Adds a Test Connection button to the datasource editor that validates connectivity before saving. The button is wired through the editor component chain (DatasourceEditorForm → PluginEditor → PluginSpecEditor) where the connection logic is bound to the plugin's healthCheckPath and the current project/dashboard context. As part of this, buildProxyUrl is also migrated to @perses-dev/client, replacing the local implementation in perses/ui/app that will be removed in a companion PR.
Screenshots
In perses/plugins#620
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: