[FEATURE] Add disable_auto_refresh config by mixturesolutions · Pull Request #212 · perses/shared

mixturesolutions · 2026-08-04T14:09:29Z

Description

Adds an optional admin config flag to centrally disable dashboard auto-refresh, addressing perses/perses#4295

Default: false (no behavior change unless explicitly enabled)

When enabled:

The auto-refresh interval dropdown is hidden in the UI
Dashboard refreshInterval and ?refresh= URL param are ignored
Follows the same pattern as disable_custom and disable_zoom

Note this is linked with another PR in the main perses repo

Screenshots

To enable, change in the respective perses config yaml file like the following:

Once the changes are deployed, config page will reflect the changes and the dashboard ui will look like:

Originally looks like:

Checklist

Pull request has a descriptive title and context useful to a reviewer.
Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
All commits have DCO signoffs.

UI Changes

Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
Code follows the UI guidelines.
E2E tests are stable and unlikely to be flaky.
See e2e docs for more details. Common issues include:
- Is the data inconsistent? You need to mock API requests.
- Does the time change? You need to use consistent time values or mock time utilities.
- Does it have loading states? You need to wait for loading to complete.

…a server config (default false) Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

jgbernalp · 2026-08-06T10:17:49Z

@mixturesolutions mind checking the tests and lint failures?

Co-authored-by: Gabriel Bernal <gabrielbernalp@gmail.com> Signed-off-by: Iris Ye <143642859+mixturesolutions@users.noreply.github.com>

Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

ibakshay

Great Job! I left a minor comment. I also tested manually. Everything is working as expected! 🚀

ibakshay · 2026-08-10T08:02:54Z

+      if (isAutoRefreshDisabled) {
+        return;
+      }


This check is redundant. The picker is disabled when isAutoRefreshDisabled is true
(line 239), so onChange never fires and this handler is never called. So, this check is safe to be removed.

Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

Gladorme · 2026-08-11T13:16:03Z

I was wondering if it is not better to "hide" the selector, instead of disabled effect?
Because having a disabled selector taking place for nothing, could be bothering (at least to me)

Maybe more a question for people that want this feature 😄

mixturesolutions · 2026-08-11T13:41:57Z

I was wondering if it is not better to "hide" the selector, instead of disabled effect? Because having a disabled selector taking place for nothing, could be bothering (at least to me)

Maybe more a question for people that want this feature 😄

@ibakshay Since you suggested the feature, what do you think?

ibakshay · 2026-08-12T11:38:23Z

I was wondering if it is not better to "hide" the selector, instead of disabled effect? Because having a disabled selector taking place for nothing, could be bothering (at least to me)
Maybe more a question for people that want this feature 😄

@ibakshay Since you suggested the feature, what do you think?

Yes, hiding is fine with me. :) @mixturesolutions

jgbernalp · 2026-08-19T16:00:13Z

+    );
+    const refreshIntervalPicker = screen.getByLabelText(/Select refresh interval/i);
+    expect(refreshIntervalPicker).not.toHaveAttribute('aria-disabled', 'true');
+    expect(screen.queryByText('Off')).not.toBeInTheDocument();


Not sure this makes sense, are we saying we hide the off option. So users cannot turn off the auto refresh? IIUC the goal is to hide the whole select component as users are not allowed to select any value. cc @ibakshay @mixturesolutions

Just to clarify, the changes hides the entire refresh interval dropdown when disabled is true. It's just in the case of my ui display during testing, the picker defaults to off option, so the comment was highlighting the "Off" as representing the disabled state of the entire picker. I changed the PR to make the comment less ambiguous. Please reference the description UI photos if it matches what you had in mind.

Thnx for the update, this test was getting the refresh interval picker and asserting content on it, but the suggestion was to remove the picker entirely as is updated now.

I saw the last change reverted, maybe we need to check again as this test is asserting something different than the proposal. The test should check that the interval picker does not exist in the DOM.

I was fixing the commit message for DCO and reverted my commits a couple times and repushed, it might have gotten the git commits out of sync with my current testing environment setup. It was my bad. Everything should be good now.

…nabled Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

Signed-off-by: Iris Ye <143642859+mixturesolutions@users.noreply.github.com>

jgbernalp · 2026-08-19T16:58:40Z

  value?: DurationString;
  onChange: (value: DurationString) => void;
  height?: string;
+  disabled?: boolean;


This is not needed as is unused, the whole component is not rendered

…om previous disabling feature Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

ibakshay

LGTM! 🚀

mixturesolutions requested a review from a team as a code owner August 4, 2026 14:09

mixturesolutions mentioned this pull request Aug 4, 2026

[FEATURE] Add disable_auto_refresh config perses/perses#4338

Open

6 tasks

[FEATURE] Allow admins to centrally disable dashboard auto-refresh vi…

e7d4d0f

…a server config (default false) Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

mixturesolutions force-pushed the feat/4295-disable-auto-refresh branch from 2e9c4cb to e7d4d0f Compare August 4, 2026 14:22

mixturesolutions changed the title ~~[FEATURE] Allow admins to centrally disable dashboard auto-refresh via server~~ [FEATURE] Add disable_auto_refresh config Aug 4, 2026

jgbernalp reviewed Aug 6, 2026

View reviewed changes

Comment thread plugin-system/src/runtime/TimeRangeProvider/TimeRangeProvider.tsx Outdated

jgbernalp reviewed Aug 6, 2026

View reviewed changes

Comment thread plugin-system/src/runtime/TimeRangeProvider/query-params.ts Outdated

mixturesolutions and others added 2 commits August 6, 2026 08:50

Update plugin-system/src/runtime/TimeRangeProvider/TimeRangeProvider.tsx

04c7920

Co-authored-by: Gabriel Bernal <gabrielbernalp@gmail.com> Signed-off-by: Iris Ye <143642859+mixturesolutions@users.noreply.github.com>

[IGNORE] Simplies commits and resolve testing errors

0482be3

Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

ibakshay reviewed Aug 10, 2026

View reviewed changes

[IGNORE] removed redundant check suggested by akshay

3eff491

Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

mixturesolutions force-pushed the feat/4295-disable-auto-refresh branch 10 times, most recently from c366771 to d2ad478 Compare August 19, 2026 15:12

mixturesolutions requested a review from jgbernalp August 19, 2026 15:42

jgbernalp reviewed Aug 19, 2026

View reviewed changes

mixturesolutions force-pushed the feat/4295-disable-auto-refresh branch 2 times, most recently from 96e91cb to fab9473 Compare August 19, 2026 16:42

[FEATURE] Hide refresh interval picker when disable_auto_refresh is e…

920c5a9

…nabled Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

mixturesolutions force-pushed the feat/4295-disable-auto-refresh branch from fab9473 to 920c5a9 Compare August 19, 2026 16:51

Merge branch 'main' into feat/4295-disable-auto-refresh

dad1325

Signed-off-by: Iris Ye <143642859+mixturesolutions@users.noreply.github.com>

jgbernalp reviewed Aug 19, 2026

View reviewed changes

mixturesolutions force-pushed the feat/4295-disable-auto-refresh branch from 087bfe3 to dad1325 Compare August 19, 2026 17:15

[IGNORE] Fixing npm lint formatting and removing unused components fr…

10a5a99

…om previous disabling feature Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>

mixturesolutions force-pushed the feat/4295-disable-auto-refresh branch from b93c6b6 to 10a5a99 Compare August 19, 2026 17:27

ibakshay approved these changes Aug 19, 2026

View reviewed changes

Uh oh!

Conversation

mixturesolutions commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots

Checklist

UI Changes

Uh oh!

jgbernalp commented Aug 6, 2026

Uh oh!

Uh oh!

Uh oh!

ibakshay left a comment

Choose a reason for hiding this comment

Uh oh!

ibakshay Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

Gladorme commented Aug 11, 2026

Uh oh!

mixturesolutions commented Aug 11, 2026

Uh oh!

ibakshay commented Aug 12, 2026

Uh oh!

jgbernalp Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

mixturesolutions Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgbernalp Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

jgbernalp Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

mixturesolutions Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgbernalp Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

ibakshay left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mixturesolutions commented Aug 4, 2026 •

edited

Loading

mixturesolutions Aug 19, 2026 •

edited

Loading

mixturesolutions Aug 19, 2026 •

edited

Loading

ibakshay left a comment •

edited

Loading