[FEATURE] pyroscope: migrate profile queries to the Connect API - #763
Open
luweglarz wants to merge 1 commit into
Open
[FEATURE] pyroscope: migrate profile queries to the Connect API#763luweglarz wants to merge 1 commit into
luweglarz wants to merge 1 commit into
Conversation
Gladorme
reviewed
Aug 14, 2026
Gladorme
left a comment
Gladorme
left a comment
Member
There was a problem hiding this comment.
Nice change. Just a issue with series chart time axis
| params: T | null, | ||
| queryOptions: QueryOptions, | ||
| body: Record<string, string | number> | ||
| body: object |
Member
There was a problem hiding this comment.
Suggested change
| body: object | |
| body: Record<string, unknown> |
| }; | ||
| } | ||
|
|
||
| export function transformTimeline(series: Series[] | undefined, fallbackStepSeconds: number): ProfileData['timeline'] { |
Member
There was a problem hiding this comment.
Something is wrong with timeline. It is not respecting selected time range.
Before:
Now:
luweglarz
force-pushed
the
pyroscope-connect-api-migration
branch
3 times, most recently
from
August 18, 2026 19:23
7eae6db to
2b2f16f
Compare
Signed-off-by: luweglarz <lucas.weglarz@amadeus.com>
luweglarz
force-pushed
the
pyroscope-connect-api-migration
branch
from
August 18, 2026 19:51
700df68 to
10e5284
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/renderis documented as Pyroscope's legacy HTTP API: https://grafana.com/docs/pyroscope/latest/reference-server-api/#querying-profile-dataThis PR is to migrates the Pyroscope plugin's profile queries from the legacy
GET /pyroscope/renderendpoint to Pyroscope's Connect API that is decoupled in 2 endpoints:
this brings profile querying in line with the rest of the pyroscope-client, which already used Connect for profile types, label names, and label values.
ProfileData's shape returned to the panel is unchanged, soFlameChartPaneland itssubcomponents needed no changes.getProfileDataitself (previously untested), covering requestbuilding, the time-range fallback, and response assembly.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.