feat(chatops): add /command for build test pr in PR - #1355
Hugo-Galley wants to merge 1 commit into
Conversation
61b8e91 to
fa119c9
Compare
|
@Hugo-Galley Thanks for the PR. I will take a look soon. Hopefully this is fine for you. |
|
I fixed the trivy issue already in a different PR. So it looks good so far. |
|
Hi @Hugo-Galley could you rebase? |
|
Hi @perber, Sorry, I’m currently on vacation and don’t have access to my PC. I won’t be able to work on this until early September. I wanted to open the PR before leaving so it was already available for review. I’ll rebase it and address any feedback once I’m back in September. Thanks for your patience! |
|
Hi @Hugo-Galley, Enjoy your vacation. |
|
Hi @Hugo-Galley, I think we should built it only when a 'maintainer' is using this command. |
fa119c9 to
3bb0157
Compare
|
Hi @perber, what do you think about using “maintainer” here? Do you mean only repository owners, or also regular contributors and approving contributors? I’m not sure which ones you’re referring to. |
|
Hi @Hugo-Galley, |
|
@perber No worries at all, took me a while to reply as well ;). Sounds good to me. I'll restrict creation to the owner only. Nothing is set in stone anyway, we can always add it back later if we change our minds :) |
Related issue
This PR references issue #1301.
What changed
/create-test-image.Checklist
npm run formatinui/leafwiki-ui(and ine2eif e2e tests changed)