feat(wall): typed exact length during two-click wall drafting

[dkbbdev]

Closes #308.

What

While drafting a wall in the two-click flow, typing an exact length (e.g. 3m, 180cm, 2500 in mm notation, 10'6") now locks the draft to that length along the current draft direction — the pointer keeps steering the direction only.

• Enter commits the wall at the typed length.
• Escape is two-stage: first press clears the typing buffer, second press cancels the draft (per the triage note on unit toggle only affects the display of dimensions, not the input #308).
• Backspace/Delete edit the buffer.
• The HUD label shows the buffer while typing and falls back to the normal drafting label when empty.

How

• New shared store useWallDraftTyping (packages/editor/src/store/use-wall-draft-typing.ts) holds the buffer so the 2D floor-plan draft and the 3D wall tool stay in lockstep per the 2D ↔ 3D parity rule in wiki/architecture/tools.md.
• 3D (packages/nodes/src/wall/tool.tsx): a window keydown listener mirrors the cabinet tool's applyTypedDimension pattern — parseMeasurement resolves the buffer with the same bare-unit defaults; grid:move projects the draft end onto the typed length; Enter synthesizes a grid:click at the projected endpoint so the normal commit pipeline (chain continuation, auto-close, support-slab election) runs unchanged.
• 2D (floorplan-panel.tsx): the same projection in the wall-draft pointer move, the same key handling in the window keydown effect, and the HUD label override.
• Angle snap / junction snap / magnetic alignment continue to work on untyped drafts; the typed commit intentionally bypasses endpoint snap so the typed length survives exactly (drafting direction is taken from the current snapped pointer, so snapped angles still steer it).

Testing

• packages/editor/src/store/use-wall-draft-typing.test.ts — buffer lifecycle + accepted keys.
• packages/nodes/src/wall/typed-length.test.ts — the projection math shared by both views.
• Full @pascal-app/editor + @pascal-app/nodes suites pass (turbo run test: 3119 tests across 268 files, plus the editor suite).
• tsgo --noEmit clean for both packages; biome check clean on touched files.

Verified end-to-end on a self-hosted deployment (design.dekorproduct.com) in both the 2D plan and 3D views with metric-m and mm notations.

Thanks for the detailed triage spec on #308 — the interaction follows it point by point.

---

Note

Medium Risk
Touches core wall placement in 2D and 3D with global key handling and commit-path snap bypass; behavior is localized to active wall drafts with tests, but regressions in chaining or preview/commit parity would be user-visible.

Overview
Adds typed exact-length wall drafting (#308) during the two-click flow in both 2D floor plan and 3D wall tool, using a new shared useWallDraftTyping store (buffer + projected endpoint).

While typing, the draft end and measurement HUD follow the buffer; the pointer only sets direction. Enter commits at the parsed length; Escape clears the buffer first, then cancels the draft; Backspace/Delete edit the buffer. Commits recompute the endpoint via resolveTypedCommitEnd so clicks and Enter match the HUD even when digits change without pointer movement; typed commits skip endpoint snap so the length stays exact.

Exports the store helpers from @pascal-app/editor. Unit tests cover the store, commit resolution, and shared projection math.

^{Reviewed by Cursor Bugbot for commit afe71e4. Bugbot is set up for automated code reviews on this repo. Configure here.}

[pascal]

I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…).

Please try again, rephrase, or reach out if it keeps failing.

Error id: 91943371-ceba-4f22-9d28-001dcd5623f3

[cursor]

Stale Bugbot comment from a previous run.

[dkbbdev]

Addressed all 5 Bugbot findings in 11e8fa5:

• Click commit ignores typed length / Enter re-snaps typed endpoint — the typing store now carries the projected endpoint (projectedEnd); click and Enter commits reuse it verbatim in both 2D and 3D, bypassing magnetic/angle/grid snap so the committed wall is exactly the previewed length.
• HUD ignores typing store updates — the 2D layer subscribes to the store (useWallDraftTyping((s) => s.input)) instead of reading getState() inside useMemo.
• Typing buffer persists after commit — clearInput() now fires on every exit path: 3D commit, 2D commit + chain continuation, clearWallPlacementDraft, cancel; removed the unused begin().
• 2D typing keys leak to shortcuts — typing/Enter/Escape handlers now stopPropagation() as well as preventDefault().

Full check-types + test suites pass (3,125 tests).

[cursor]

Stale Bugbot comment from a previous run.

[dkbbdev]

Round 2 findings fixed in 596c7e7:

• 3D Enter re-snaps the typed endpoint — the buffer now survives the synthetic grid:click (commit recognized as typed, snap bypassed), with a defensive clear after in case the commit path bails early.
• Stopped draft keeps typed buffer — stopDrafting clears the typing store, so double-click finish and chain auto-close no longer leak the old length into the next draft.
• 2D Enter uses a stale callback — the placement callback is now kept current via a useEffect latest-ref instead of self-assigning on first call; typed Enter commits the wall instead of restarting the draft. The 2D move preview also publishes projectedEnd so a click mid-type commits the projected endpoint, matching 3D.

check-types + biome + full test suite pass.

[cursor]

Stale Bugbot comment from a previous run.

[dkbbdev]

(merged upstream/main @ 5ce7211 — hosting/duplicate fixes in; no conflicts; CI green pre-merge)

[dkbbdev]

@Aymericr gentle ping for review priority when you have a moment 🙂 This addresses #308 (the unit toggle currently affecting display only, not input) — typed exact length during two-click wall drafting. The branch is up to date with main as of today (merged cleanly, no conflicts, Cursor Bugbot neutral). We're planning to build further exact-input features on this base, so an early review would help us stay aligned with the direction you'd prefer. Happy to split it into smaller pieces if that eases review.

[dkbbdev]

Round 3 finding (Bugbot 8497d792, high: "click commits stale typed length") fixed in afe71e4:

• append/backspace only change the buffer while projectedEnd was published by the last pointer move — digits typed after that move left the click commit using a stale endpoint (type 1 then 2 without moving → committed 1 m, not 12 m). Enter already re-parsed and re-projected.
• New shared resolveTypedCommitEnd(start, currentEnd, input, parseOpts) re-derives the endpoint from the live draft direction at commit time; both the 3D grid-click path and the 2D floor-plan placement callback now use it, falling back to the last projected end only when there is no usable direction.
• The 2D move preview dependency array now lists unit/metricNotation so the parse options stay in sync across unit changes.
• Unit tests cover stale-buffer re-derivation, direction normalization, unit suffixes, and null fallbacks. check-types + biome + editor (1072) + nodes (3392) suites pass.

Also includes the upstream/main merge (hosting fixes #894–#896, settings dialog #904, cli #893) noted earlier — no conflicts.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit afe71e4. Configure here.}

[cursor]

Enter skips 2D wall commit

High Severity

The 3D capture-phase Enter handler synthesizes grid:click and stops the event, so the 2D Enter path never runs handleWallPlacementPoint. In 2D-only that click path is documented as not creating a wall, so Enter commits nothing. In split view the 3D tool commits but local draftStart stays on the previous segment, so the next 2D preview and typed commit use the wrong origin.

Additional Locations (2)

• packages/editor/src/components/editor/floorplan-panel.tsx#L8296-L8326
• packages/editor/src/components/editor/floorplan-panel.tsx#L9890-L10015

 

^{Reviewed by Cursor Bugbot for commit afe71e4. Configure here.}