Document the -i and --id alternatives to --identifier - #1172
centosinfra-prod-github-app[bot] merged 1 commit into
Conversation
|
🤖 Finished Review · ❌ Failure (creating sandbox: sandbox creation failed after 3 attempts: sandbox create failed: exit status 2 (output: error: unexpected argument '--detach' found tip: to pass '--detach' as a value, use '-- --deta…) · Started 3:55 PM UTC · Completed 3:55 PM UTC Commit: Effort: high |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 09s |
The shorter alternatives to the `--identifier` test option lacked documentation previously. This has now been fixed so that the docs are comprehensive in what is supported.
fad697f to
623a063
Compare
|
🤖 Finished Review · ❌ Failure (creating sandbox: sandbox creation failed after 3 attempts: sandbox create failed: exit status 2 (output: error: unexpected argument '--detach' found tip: to pass '--detach' as a value, use '-- --deta…) · Started 4:39 PM UTC · Completed 4:40 PM UTC Commit: Effort: high |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 17s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 07s |
3470bfb
into
packit:main
3 participants
It appears that the
-iand--idalternatives to the--identifiertest argument are missing from the docs.I believe these alternatives are supported based on the following line of code in
packit-service:https://github.com/packit/packit-service/blob/c1f019130b4e81a0c366a4886230a0115967eee8/packit_service/worker/helpers/testing_farm.py#L119
Existing tests also support this belief:
https://github.com/packit/packit-service/blob/c1f019130b4e81a0c366a4886230a0115967eee8/tests/unit/test_testing_farm.py#L2156-L2177