Fix calmarg forwarding of ChooseFDModes frame options - #192
Merged
oshaughn merged 1 commit intoSep 11, 2026
Merged
Conversation
oshaughnessy-junior
deployed
to
private-review-dispatch-rift-upstream
September 11, 2026 15:00 — with
GitHub Actions
Active
oshaughn
deployed
to
private-review-dispatch-rift-upstream
September 11, 2026 15:17 — with
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR 183 corrected the ChooseFDModes J-to-L rotation, but calibration reweighting supplied its options as one extra_waveform_kwargs catch-all keyword. hlmoft never read that nested bundle, so fd_L_frame remained false on the calmarg source path. XPHM calmarg could therefore use unrotated J-frame modes while ILE used L-frame modes.
Adversarial validation
Environment caveat
The local LALSimulation 6.1.0 provides XPHM and XO4a but not XPNR. A pre-existing grouped optional import in RIFT consequently masks all three identifiers. For the waveform validation only, the installed XPHM identifier was restored at runtime so the PR 183 route could be exercised. No workaround for that separate compatibility defect is included here.