ILE: add accurate reflected Q time pregrid

.travis/ci_roster.txt

@@ -95,8 +95,8 @@ MonteCarloMarginalizeCode/Code/demo/rift/export_likelihoods/head_to_head/run_tes
 # The two jax_gp files are the strongest candidates for promotion: jax-ile-check already
 # installs a CPU jax stack, so adding them there costs only optax and a raised EXPECTED_TESTS.
 # Not done here because that job's counts are pinned and this PR does not own them.
-MonteCarloMarginalizeCode/Code/RIFT/interpolators/jax_gp/test_coordinates.py   OPTDEP  needs jax; belongs in jax-ile-check, which already installs a CPU jax stack
-MonteCarloMarginalizeCode/Code/RIFT/interpolators/jax_gp/test_interpolators.py OPTDEP  needs jax and optax; 10 collected, all 10 error on ModuleNotFoundError optax rather than skipping
+MonteCarloMarginalizeCode/Code/RIFT/interpolators/jax_gp/test_coordinates.py   OPTDEP  needs jax; skips cleanly without it, 2 tests with it; belongs in jax-ile-check, which already installs a CPU jax stack
+MonteCarloMarginalizeCode/Code/RIFT/interpolators/jax_gp/test_interpolators.py OPTDEP  needs jax and optax; skips cleanly without either, 10 tests where both are installed
 # The two cupy parity legs are NOT listed here.  PR #242 landed, and its
 # .travis/test-q-window-stencil.sh names both in an EXCLUDED array -- with the same reason,
 # and with its own fail-closed check that an EXCLUDED path still exists and does not carry
@@ -114,23 +114,23 @@ MonteCarloMarginalizeCode/Code/test/integrators/test_mcsamp_vegas.py           O
 MonteCarloMarginalizeCode/Code/test/integrators/test_mcsampler_rosenbrock.py   HANDRUN  Rosenbrock sampler study; its docstring pairs it with plot_posterior_corner.py by hand
 MonteCarloMarginalizeCode/Code/test/test_eosmanager_misc.py                    OPTDEP  needs LALSIMULATION_DATADIR set; raises KeyError at import without it
 MonteCarloMarginalizeCode/Code/test/test_skysamp.py                            LEGACY  imports lalinference.bayestar.fits, removed upstream; cannot be imported
-MonteCarloMarginalizeCode/Code/test/test_mcsampler_foridiots.py                BROKEN  NameError int_vals at import; a plotting demo that no longer runs at all
+# test_mcsampler_foridiots.py is HANDRUN rather than BROKEN because it is a demo script with no
+# test functions -- it was never going to be gated.  But it fails for a reason that is NOT the
+# demo's: it dies in RIFT/integrators/mcsamplerGPU.py:1324, inside integrate(), on
+#
+#     weights_alt = int_vals**tempering_exp        # NameError: int_vals is not defined
+#
+# the `not save_intg` branch of the adaptation weighting.  `int_vals` exists nowhere in that
+# scope; the sibling branches use self._rvs["integrand"][-n_history:], and the local holding the
+# same values when nothing is being saved is `fval` (a commented-out line two above prints it),
+# so `fval**tempering_exp` is the near-certain intent.  This branch cannot ever have run.
+#
+# NOT FIXED HERE: that is core sampler code, and guessing the intended expression is exactly the
+# kind of change that should be RO'S call rather than a side effect of a test-hygiene PR.
+# Reported instead.  Reachable on CPU -- this demo hit it with no GPU involved.
+MonteCarloMarginalizeCode/Code/test/test_mcsampler_foridiots.py                HANDRUN  plotting demo with no test functions; dies in mcsamplerGPU.integrate on an undefined int_vals (see note above)
 
 # ---------------------------------------------------------------------------------------
 # EXPENSIVE -- correctly gated already, by an env var rather than by CI membership.
 MonteCarloMarginalizeCode/Code/test/expensive_before_merging/integrators/test_shape_recovery.py          EXPENSIVE  4 collected, all skip unless RIFT_RUN_EXPENSIVE=1
 MonteCarloMarginalizeCode/Code/test/expensive_before_merging/integrators/test_escaped_mass_diagnostic.py EXPENSIVE  5 collected, all skip unless RIFT_RUN_EXPENSIVE=1
-
-# ---------------------------------------------------------------------------------------
-# BROKEN -- collects and FAILS on rift_O4d today.  Found only because this audit ran them.
-#
-# test_replica_pooling.py is the clearest argument for the census.  It loads six helpers out of
-# bin/integrate_likelihood_extrinsic_batchmode by REGEX and exec()s them into a synthetic
-# module.  The driver has since been refactored so that _lnZ_of_rvs and _kish_neff_of_rvs
-# delegate to a seventh helper, _lw_of, which the regex list does not extract.  Inside the
-# exec'd module _lw_of is undefined; the driver's own `except Exception: return None` swallows
-# the NameError, both helpers return None, and 10 of 15 tests die on `None - float`.  Adding
-# "_lw_of" to the slice list in the test is the immediate fix.  The reimplemented-harness shape
-# is the real problem and outlives that fix.
-MonteCarloMarginalizeCode/Code/test/integrators/test_replica_pooling.py  BROKEN  10 of 15 fail; its regex helper-slicer misses _lw_of, added to the driver after the test was written
-MonteCarloMarginalizeCode/Code/test/hyperpipe/tests/test_marg_list.py    BROKEN  2 of 3 fail; _stage_event_file writes event-N.net into base_dir while the test and assemble_marg_list's own run_dir docstring say run_dir

.travis/test-core-units.sh

@@ -11,8 +11,11 @@
 # distance grid, a container manifest, a parameter port.  A wrong number there is still a
 # plausible number.
 #
-# Every file listed here was run individually on CIT (IGWN conda python 3.11, numpy 1.26.4,
-# lal 7.7.0) before it was added; the measured collection counts are the floors below.
+# The original manifest was run file by file on CIT (IGWN conda python 3.11, numpy 1.26.4,
+# lal 7.7.0) before it was added; the measured collection counts are the floors below.  Later
+# entries are verified by this gate itself, which collects every file individually before the
+# combined run, so an addition that collects nothing or fails is caught here rather than
+# trusted on a quoted number.
 #
 # SHAPE.  Modelled on .travis/test-slowrot.sh, and it keeps that script's defences, because
 # the trap it documents is live in this very set: several files elsewhere in these directories
@@ -58,11 +61,14 @@ FILES=(
   "$C/RIFT/likelihood/test_td_dispatch_epoch.py"
   "$C/test/test_ile_scalar_edge_cases.py"
   "$C/test/test_srate_resample_time_marginalization.py"
+  "$C/test/test_vectorized_lal_tools_split.py"
+  "$C/test/test_noloop_accumulator_shapes.py"
   # -- integrators: seeding, allocation, weight derivation
   "$C/test/integrators/test_convergence_sample_order.py"
   "$C/test/integrators/test_gmm_adaptive.py"
   "$C/test/integrators/test_portfolio_gmm_member_trains.py"
   "$C/test/integrators/test_portfolio_restrict_and_warm.py"
+  "$C/test/integrators/test_replica_pooling.py"
   "$C/test/integrators/test_rvs_weight_derivation.py"
   "$C/test/integrators/test_seeding_public_paths.py"
   "$C/test/integrators/test_seeding_reproducibility.py"
@@ -77,6 +83,7 @@ FILES=(
   "$C/test/hyperpipe/tests/test_config.py"
   "$C/test/hyperpipe/tests/test_coords.py"
   "$C/test/hyperpipe/tests/test_drivers.py"
+  "$C/test/hyperpipe/tests/test_marg_list.py"
   "$C/test/test_hyperpipeline_io.py"
   # -- packaging / config contracts / waveform conventions
   "$C/test/test_advanced_parameter_ports.py"
@@ -113,9 +120,23 @@ done
 
 # Pinned TOTAL floor, so a renamed file or a dropped test_* entry point goes red rather than
 # green-on-fewer-tests.  MEASURED 2026-09-03 on CIT with the IGWN conda python (3.11, numpy
-# 1.26.4, scipy 1.14.1, lal 7.7.0), whole manifest in one run: 278 collected, 266 passed,
-# 12 skipped (11 pytest.skip + 1 xfail), 49 s.
-EXPECTED_TESTS=278
+# 1.26.4, scipy 1.14.1, lal 7.7.0), whole manifest in one run: 296 collected, 284 passed,
+# 12 skipped (11 pytest.skip + 1 xfail), ~55 s.  (Was 278/266 before test_replica_pooling.py
+# and test_marg_list.py joined the manifest -- both were rostered BROKEN until their defects
+# were fixed.  RAISE these when files are added: a floor left at the old value passes while
+# covering less, which is the failure this gate exists to catch.)
+#
+# +3/+3 for test_vectorized_lal_tools_split.py: three unconditional test functions, no skip
+# and no xfail, numpy / lal / lalsimulation only, so both floors move by the same amount and
+# MAX_SKIPPED does not.
+#
+# +8/+8 for test_noloop_accumulator_shapes.py: two parametrized over three detector networks
+# (1/2/3 IFOs) plus two unconditional, so 8 collected and 8 passed, no skip and no xfail.
+# numpy / lal / lalsimulation only -- it builds synthetic inputs and calls the NoLoop
+# likelihood on the CPU backend, so it needs no cupy and no GPU, and both floors move by the
+# same amount while MAX_SKIPPED does not.  MEASURED 2026-09-05 on CIT with the same conda
+# python as the line above: 8 collected, 8 passed, 0 skipped, 4.9 s.
+EXPECTED_TESTS=307
 # Outcomes, not just exit status: a collection floor cannot see a test that collects, runs and
 # asserts nothing, and a pytest.skip can quietly absorb a lost gate.  The 12 skips are
 # environment legs -- cupy in test_seeding_reproducibility, device legs in
@@ -126,7 +147,7 @@ EXPECTED_TESTS=278
 # editable install) reported the same 278 / 266 / 12, in 24.7 s.  So these floors are exact on
 # both stacks, not merely the CIT numbers copied across, and a future divergence is a real
 # change rather than an environment difference to be explained away.
-EXPECTED_PASSED=266
+EXPECTED_PASSED=295
 MAX_SKIPPED=12
 
 junit="$(mktemp -t core-units-junit-XXXXXX.xml)"

.travis/test-integrate.sh

@@ -72,7 +72,7 @@ _TMARG_TESTS=(
 # catches a total collection failure (pytest exits 5), but a silent shrink from 60
 # tests to 3 -- a rename, a stale -k, a decorator that stops matching -- reads as
 # green.  Raise EXPECTED by RUNNING collection, never by arithmetic.
-_TMARG_EXPECTED=161
+_TMARG_EXPECTED=171
 _TMARG_FOUND=$(python -m pytest -q --collect-only "${_TMARG_TESTS[@]}" 2>/dev/null | grep -c '::' || true)
 if [ "$_TMARG_FOUND" -ne "$_TMARG_EXPECTED" ]; then
     echo "time-marginalization gate: collected $_TMARG_FOUND tests, expected $_TMARG_EXPECTED" >&2
@@ -137,11 +137,14 @@ fi
 # protect: that the outside supremum is CERTIFIED (a straddling cell must count as
 # outside -- classifying grid centres once returned "nothing uncovered" and accepted
 # unconditionally), that a distance node is only dropped when the drop is provable
-# against the computed value, and that an undersized region is DECLINED rather than
-# returned.
+# against the computed value, and that an undersized region is routed to the finite
+# dense fallback rather than returned locally.  The algebraic follow-up also pins
+# the BKK/resultant enumerator on co-dominant, near-annihilating, exactly degenerate,
+# and amplitude-scaled systems, requires inside-cover convergence even after a
+# complete enumeration, and keeps the NumPy fallback independent of optional JAX.
 _JOINT_PL_TESTS=MonteCarloMarginalizeCode/Code/test/test_joint_angle_peak_local.py
 # Raise EXPECTED by RUNNING collection, never by arithmetic.
-_JOINT_PL_EXPECTED=26
+_JOINT_PL_EXPECTED=36
 _JOINT_PL_FOUND=$(python -m pytest -q --collect-only "$_JOINT_PL_TESTS" 2>/dev/null | grep -c '::' || true)
 if [ "$_JOINT_PL_FOUND" -ne "$_JOINT_PL_EXPECTED" ]; then
     echo "joint peak-local gate: collected $_JOINT_PL_FOUND tests, expected $_JOINT_PL_EXPECTED" >&2

.travis/test-jax.sh

@@ -339,6 +339,7 @@ FILES=(
   "${JAXDIR}/test_jax_stencil_parity.py"
   "${JAXDIR}/test_flow_reuse_default.py"
   "${JAXDIR}/test_angle_marg_sizing_rule.py"
+  "${JAXDIR}/test_anglemarg_buffer_cap.py"
   "${JAXDIR}/test_angle_marg_smoke.py"
   "${JAXDIR}/test_angle_marg_compile_cost.py"
   "${JAXDIR}/test_angle_marg_block_dispatch.py"
@@ -349,6 +350,8 @@ FILES=(
   "${JAXDIR}/test_joint_anglemarg_peaklocal.py"
   "${JAXDIR}/test_angle_marg_peaklocal_wiring.py"
   "${JAXDIR}/test_limit_distance_jax.py"
+  "${JAXDIR}/test_direct_marginalization_planner.py"
+  "${JAXDIR}/test_time_first_peaklocal.py"
 )
 
 # EXCLUDED: files in JAXDIR matching test_*.py that are deliberately NOT gated.  The
@@ -477,7 +480,38 @@ fi
 # test_joint_anglemarg_peaklocal.py (twice differentiable, and the gradient stays
 # finite as the quartic leading coefficient vanishes).  293 + 13 = 306, re-derived
 # by RUNNING the gate's own collection after rebasing over #221/#238/#223.
-EXPECTED_TESTS=306
+#
+# The u-FALLBACK branch adds 2 in test_joint_anglemarg_peaklocal.py (required_u_nodes
+# is derived and follows the sqrt-A law under a cap, and a whole-cell integration sized
+# by it agrees with a 4x finer one).  The floor is 310, READ FROM THIS JOB'S OWN LOG.
+# Two wrong numbers preceded it, failing in opposite directions:
+#   308 -- by adding 2 to the previous 306, which is exactly what the paragraph above
+#          says not to do.  The base is 309 after #239 merged, so 308 would still have
+#          PASSED while silently under-promising three tests.
+#   311 -- by running the collection on a dev host.  Wrong by exactly one, because the
+#          harness sliced this script by line number to reuse FILES and stopped before
+#          the loop that populates DESELECT from DESELECTED_TESTS -- so it counted
+#          test_gpu_gather_parity_against_numpy_window, which THIS job deselects.
+# Arithmetic lands below the truth and passes; a mis-set-up local collection lands above
+# it and fails.  Read the floor off this job's "collected N tests from 27 files" line --
+# the only source that is not a guess.
+# The production-policy follow-up adds one mutation-bearing streaming test; this job's
+# own collection reports 312.
+# PR #250 adds test_anglemarg_buffer_cap.py, test_direct_marginalization_planner.py and
+# test_time_first_peaklocal.py; 247 adds four tests to test_joint_anglemarg_peaklocal.py
+# and REMOVES test_joint_angle_algebraic.py with the duplicate enumerator it covered.
+# Neither branch guessed well: 250 derived a provisional 408 from arithmetic and said to
+# replace it with a real collection, and 247 measured 329 against a different file set.
+# This number is the MERGED collection, run over this job own FILES/DESELECT with the
+# DESELECT loop actually applied (the run reports "424/425 tests collected (1 deselected)").
+#
+# 250 also inferred a standing "this environment collects one more than CI" offset and
+# subtracted it.  There is no such offset: the 311 case documented above was wrong by one
+# because a harness sliced this script by line number and never ran the DESELECT loop, so
+# it counted the one test this job deselects.  That was a one-off setup bug, not a property
+# of the environment, and subtracting for it would under-promise by one -- which is the
+# failure direction this whole comment exists to warn about, because a low floor PASSES.
+EXPECTED_TESTS=424
 
 echo "== collection floor check (expect >= ${EXPECTED_TESTS} tests) =="
 collect_out="$("${PYTHON_BIN}" -m pytest --collect-only -q -p no:cacheprovider "${DESELECT[@]}" "${FILES[@]}" 2>&1)"

.travis/test-q-window-stencil.sh

@@ -136,9 +136,21 @@ SCOPE_GLOBS=(
 #                                 skips as a failure.  Run by hand on a GPU node; the
 #                                 numbers are in PR #97.  Same treatment as the GPU files
 #                                 in slowrot-check.
+#
+#   test_noloop_accumulator_    Belongs to another job, not to a GPU.  It matches the
+#   shapes.py                   test_noloop_* pattern by NAME but not by subject: it pins
+#                               NoLoop's rho_sq and kappa_sq ACCUMULATOR shapes against a
+#                               reference, and its time-integral test is about the
+#                               quadrature rule, not about sub-sample interpolation of
+#                               Q_lm.  It is registered with core-unit-check, whose FILES
+#                               manifest carries it and whose floors count it.  Listed
+#                               here rather than renamed so the decision is recorded where
+#                               the next such file will hit it: renaming to dodge a
+#                               manifest is how these gates quietly stop covering things.
 EXCLUDED=(
   "${CODEDIR}/RIFT/likelihood/test_q_window_interp_gpu.py"
   "${CODEDIR}/RIFT/likelihood/test_noloop_gpu_stencils.py"
+  "${CODEDIR}/test/test_noloop_accumulator_shapes.py"
 )
 
 echo "== registered files (marker: ${MARKER}) =="
@@ -210,15 +222,15 @@ fi
 #   EXPECTED_TESTS   `pytest --collect-only -q` over the registered files.
 #   EXPECTED_PASSED  the "N passed" from a full run (tests minus skips).
 # Never lower either without saying why in the commit message.
-EXPECTED_TESTS=69
-EXPECTED_PASSED=67
+EXPECTED_TESTS=78
+EXPECTED_PASSED=75
 
 # The only legitimate skips here are the two cupy legs -- one in
 # test_noloop_time_marg_row_offset.py, one in test_calmarg_running_max_row_offset.py --
 # which pytest.importorskip's away on these GPU-less runners.  A THIRD skip means a gate
 # was disabled, which is the exact shape this script exists to prevent, so cap it rather
 # than letting skips absorb losses silently.
-MAX_SKIPS=2
+MAX_SKIPS=3
 
 # PER-FILE collection floor.  A registered file that collects nothing contributes zero
 # gates while looking like membership; on its own pytest would exit 5 on it, and inside a

MonteCarloMarginalizeCode/Code/RIFT/hyperpipe/marg_list.py

@@ -155,19 +155,29 @@ def _stage_event_file(
     base_dir: str,
     run_dir: str,
 ) -> Tuple[str, bool]:
-    """Materialize this entry's event file at base_dir/event-<indx>.net.
+    """Materialize this entry's event file at run_dir/event-<indx>.net.
 
     Returns ``(abs_path, is_empty_sentinel)``. If the entry has no
     ``event-file`` set, we write a sentinel file with the single token
     ``empty_event_file`` so the downstream pipeline still sees a
     well-formed input.
+
+    Sources resolve against ``base_dir`` (where the user's config paths are
+    relative to); the staged copy is written to ``run_dir``. That split is
+    what :func:`assemble_marg_list` documents, and what the exe staging a
+    few lines below already does. The destination used to be ``base_dir``,
+    with ``run_dir`` accepted and unused: under hydra those are different
+    directories -- ``base_dir`` is the ORIGINAL cwd the user launched from,
+    ``run_dir`` the per-run output dir -- so the staged files landed in the
+    launch directory, and two runs started from one directory overwrote each
+    other's ``event-<i>.net``.
     """
     src = None
     if hasattr(entry, "get"):
         src = entry.get("event-file") or entry.get("event_file")
     elif "event-file" in entry:
         src = entry["event-file"]
-    dest = os.path.join(base_dir, f"event-{indx}.net")
+    dest = os.path.join(run_dir, f"event-{indx}.net")
     if src:
         src = os.path.expanduser(src)
         if not os.path.isabs(src):