chore: gitignore Claude Code local settings - #1284
Closed
ogenstad wants to merge 1 commit into
Closed
Conversation
Ignore .claude/settings.local.json, Claude Code's per-developer local overrides file. The shared .claude/ config (commands, rules, skills) stays tracked; only the local settings file is excluded.
Deploying infrahub-sdk-python with
|
| Latest commit: |
dbb080d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07a47433.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-em-gitignore-claude-loca.infrahub-sdk-python.pages.dev |
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".gitignore">
<violation number="1" location=".gitignore:46">
P3: The new rule is a no-op: line 7 `**/*.local.*` already matches and ignores `.claude/settings.local.json`. git check-ignore against a clean repo with only that pattern confirms it is already covered, so this added line changes nothing. Remove it (or the intent is already satisfied by the existing pattern).</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| .specify/feature.json | ||
|
|
||
| # Claude Code per-developer local settings (shared config stays tracked) | ||
| .claude/settings.local.json |
Contributor
There was a problem hiding this comment.
P3: The new rule is a no-op: line 7 **/*.local.* already matches and ignores .claude/settings.local.json. git check-ignore against a clean repo with only that pattern confirms it is already covered, so this added line changes nothing. Remove it (or the intent is already satisfied by the existing pattern).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .gitignore, line 46:
<comment>The new rule is a no-op: line 7 `**/*.local.*` already matches and ignores `.claude/settings.local.json`. git check-ignore against a clean repo with only that pattern confirms it is already covered, so this added line changes nothing. Remove it (or the intent is already satisfied by the existing pattern).</comment>
<file context>
@@ -41,3 +41,6 @@ infrahub_sdk/_version.py
.specify/feature.json
+
+# Claude Code per-developer local settings (shared config stays tracked)
+.claude/settings.local.json
</file context>
Contributor
Author
|
Closing: this change is a no-op. The existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ignore
.claude/settings.local.json- Claude Code's per-developer local settings file (personal permission allowlists and local overrides).Why
.claude/settings.jsonand is meant to stay out of version control..claude/(commands,rules,skills), so.claude/isn't blanket-ignored; this adds a surgical ignore for just the local settings file.git statusfor every developer and risks being committed by accident.Verified
.claude/settings.local.jsonis not currently tracked, so the ignore rule alone is sufficient (nogit rm --cachedneeded).Summary by cubic
Ignores Claude Code's per-developer local settings file (
.claude/settings.local.json) so it no longer appears ingit statusor risks being committed. Shared.claude/config stays tracked, and since the file isn't currently tracked, nogit rm --cachedis needed.Written for commit dbb080d. Summary will update on new commits.