feat: expose RoPE theta via config API - #320
Open
KakaruHayate wants to merge 1 commit into
Open
Conversation
KakaruHayate
force-pushed
the
feat/expose-rope-config
branch
2 times, most recently
from
August 8, 2026 03:42
ffba20b to
3956360
Compare
KakaruHayate
changed the title
KakaruHayate
force-pushed
the
feat/expose-rope-config
branch
from
August 8, 2026 04:00
3956360 to
f5ba7b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thetathrough DiffSinger YAML configs (rope_theta).rope_thetais passed toRoPEmodules in acoustic/variance/Melody encoders viahparams.rope_theta=10000preserves existing behavior when unset.Files changed
modules/fastspeech/tts_modules.py:FastSpeech2Encoderacceptsrope_theta.modules/fastspeech/acoustic_encoder.py,modules/fastspeech/variance_encoder.py: readrope_thetafrom hparams.configs/*.yamlandconfigs/templates/*.yaml: addrope_theta: 10000.