feat(config): add safe-exec profile fields - #3
Closed
pshickeydev wants to merge 1 commit into
Closed
pshickeydev wants to merge 1 commit into
pshickeydev wants to merge 1 commit into
Conversation
Add two optional per-profile fields to config/v1/safe-exec-profiles.schema.json, consumed by traust-engine >= 0.2.1: keep_env_heads (segment heads that receive keep_env/extra_env at run time) and curl_allowed_hosts (exact-hostname allowlist for curl operands). Additive; the schema remains permissive.
Contributor
|
@pshickeydev so if I'm reading those PRs correctly, you want to restrict what can run Curl and then use a json config file so folks can add new destinations, correct? I actually think we do need a config for this, otherwise it's going to become unwieldy and undocumented. But why isn't it templatized in traust/config? Why would we put configs in the traust-contracts? CC @smith-xyz |
Author
|
Wrong place for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two optional per-profile fields to
config/v1/safe-exec-profiles.schema.json:keep_env_heads— segment heads that receivekeep_env/extra_envat run time
curl_allowed_hosts— exact-hostname allowlist for curl operandsWhy
Both fields gate hardening on the
traust-engineside (>= 0.2.1),which needs the schema to accept them before the behaviour can be
configured at all. Companion PR: openshift/traust-engine#8
Additive and opt-in: the schema stays permissive and existing configs
validate unchanged.
Notes
CHANGELOG.mdsection, asci/gates.pyrequires.gates.py mrclean.