Skip to content

Add AI analysis to all medik8s operators - #83809

Open
abrugaro wants to merge 3 commits into
openshift:mainfrom
abrugaro:add-ai-analysis-to-all-operators
Open

Add AI analysis to all medik8s operators#83809
abrugaro wants to merge 3 commits into
openshift:mainfrom
abrugaro:add-ai-analysis-to-all-operators

Conversation

@abrugaro

@abrugaro abrugaro commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Adds the claude-ai-helpers:latest CI image to Medik8s operator test configurations.
  • Configures OpenShift E2E jobs to run their test command through TEST_STEPS.
  • Adds medik8s-analyze-e2e-failure as a post-test step for failure analysis.
  • Extends the same failure-analysis workflow to 16 Medik8s system-test configurations while preserving existing post steps.

Signed-off-by: Alejandro Brugarolas <abrugaro@redhat.com>
Signed-off-by: Alejandro Brugarolas <abrugaro@redhat.com>
Signed-off-by: Alejandro Brugarolas <abrugaro@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2026
@abrugaro abrugaro changed the title Add AI analysis to all operators Add AI analysis to all medik8s operators Aug 21, 2026
@abrugaro

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@abrugaro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b1d8da3-4dd0-4684-8950-9a624ed71d05

📥 Commits

Reviewing files that changed from the base of the PR and between 17f1b98 and 0ed8405.

📒 Files selected for processing (16)
  • ci-operator/config/medik8s/fence-agents-remediation/medik8s-fence-agents-remediation-main__4.22.yaml
  • ci-operator/config/medik8s/fence-agents-remediation/medik8s-fence-agents-remediation-main__4.23.yaml
  • ci-operator/config/medik8s/fence-agents-remediation/medik8s-fence-agents-remediation-main__5.0.yaml
  • ci-operator/config/medik8s/machine-deletion-remediation/medik8s-machine-deletion-remediation-main__4.22.yaml
  • ci-operator/config/medik8s/machine-deletion-remediation/medik8s-machine-deletion-remediation-main__4.23.yaml
  • ci-operator/config/medik8s/machine-deletion-remediation/medik8s-machine-deletion-remediation-main__5.0.yaml
  • ci-operator/config/medik8s/node-maintenance-operator/medik8s-node-maintenance-operator-main__4.22.yaml
  • ci-operator/config/medik8s/node-maintenance-operator/medik8s-node-maintenance-operator-main__4.23.yaml
  • ci-operator/config/medik8s/node-maintenance-operator/medik8s-node-maintenance-operator-main__5.0.yaml
  • ci-operator/config/medik8s/self-node-remediation/medik8s-self-node-remediation-main__4.22.yaml
  • ci-operator/config/medik8s/self-node-remediation/medik8s-self-node-remediation-main__4.23.yaml
  • ci-operator/config/medik8s/self-node-remediation/medik8s-self-node-remediation-main__5.0.yaml
  • ci-operator/config/medik8s/storage-based-remediation/medik8s-storage-based-remediation-main__4.22.yaml
  • ci-operator/config/medik8s/storage-based-remediation/medik8s-storage-based-remediation-main__4.23.yaml
  • ci-operator/config/medik8s/storage-based-remediation/medik8s-storage-based-remediation-main__5.0.yaml
  • ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

Medik8s CI configurations add the claude-ai-helpers image, select E2E test steps, and run medik8s-analyze-e2e-failure after tests across release and system-test configurations.

Changes

Medik8s CI configuration

Layer / File(s) Summary
Add Claude helper image
ci-operator/config/medik8s/{fence-agents-remediation,machine-deletion-remediation,node-maintenance-operator,self-node-remediation,storage-based-remediation}/*
Adds the claude-ai-helpers image from the ci namespace with the latest tag.
Configure E2E failure analysis
ci-operator/config/medik8s/{fence-agents-remediation,machine-deletion-remediation,node-maintenance-operator,self-node-remediation,storage-based-remediation}/*
Sets TEST_STEPS and adds medik8s-analyze-e2e-failure as a post step.
Extend system-test workflows
ci-operator/config/medik8s/system-tests/*
Adds test identifiers, test step selectors, and failure-analysis post steps to 16 system-test configurations. Existing post steps remain in place.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 0ed84

The PR adds post-test AI analysis to Medik8s CI jobs. The analysis depends on the inner test step being named e2e-test; if that name differs, failure artifacts may not be located, so the change is mergeable with explicit owner confirmation of the step name and regenerated CI definitions.

Suggested reviewers: jonahsussman, razo7


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error New post-step refs activate an analyzer that echoes a gcsweb-ci internal URL and tees verbose Claude output into job artifacts/logs. Redact the Prow URL and sanitize Claude output and fetched artifacts before logging or publishing them.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (16 skipped: 16 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull-request diff changes only 16 CI YAML files. Added TEST_NAME values and step refs are static, and no changed file contains Ginkgo title constructs such as It(), Describe(), Context(), or Wh...
Test Structure And Quality ✅ Passed The PR changes only 16 CI YAML files; the diff contains no Ginkgo test code or Ginkgo constructs, so the specified test-quality checks are inapplicable.
Microshift Test Compatibility ✅ Passed The PR changes only 16 YAML CI configurations; no new Ginkgo declarations or test source files were added, so this MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR diff contains only 16 YAML CI configuration files and no added Ginkgo declarations or test source, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The cumulative diff changes only CI YAML image, TEST_NAME/TEST_STEPS, and post-step fields; it adds no affinity, topology spread, replica, node selector, toleration, or PDB constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only 16 YAML configurations: base image, TEST_STEPS, and a post-step reference. No OTE binary, main, suite setup, or stdout-writing source code changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only CI YAML. It adds no Ginkgo test declarations, IPv4 literals, URL construction, or test network logic.
No-Weak-Crypto ✅ Passed The PR diff adds only CI image references, environment values, and analyzer post-step refs; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were introduced.
Container-Privileges ✅ Passed The PR diff adds image references, environment variables, and post-step refs only; it adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings.
Title check ✅ Passed The title clearly summarizes the main change: adding AI failure analysis to all listed Medik8s operator configurations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abrugaro
Once this PR has been reviewed and has the lgtm label, please assign jmontleon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2026
@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Hi @abrugaro. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@abrugaro: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-medik8s-machine-deletion-remediation-main-4.23-ci-bundle-machine-deletion-remediation-bundle medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.23-images medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.23-openshift-e2e medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.23-test medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.23-tls-pqc-readiness medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.23-tls13-adherence medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-5.0-ci-bundle-machine-deletion-remediation-bundle medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-5.0-images medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-5.0-openshift-e2e medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-5.0-test medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-5.0-tls-pqc-readiness medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-5.0-tls13-adherence medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.22-ci-bundle-machine-deletion-remediation-bundle medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.22-images medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.22-openshift-e2e medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.22-test medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-machine-deletion-remediation-main-4.22-tls-pqc-readiness medik8s/machine-deletion-remediation presubmit Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.22-ci-bundle-my-bundle medik8s/storage-based-remediation presubmit Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.22-images medik8s/storage-based-remediation presubmit Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.22-openshift-e2e medik8s/storage-based-remediation presubmit Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.22-tls-pqc-readiness medik8s/storage-based-remediation presubmit Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.23-ci-bundle-my-bundle medik8s/storage-based-remediation presubmit Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.23-images medik8s/storage-based-remediation presubmit Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.23-openshift-e2e medik8s/storage-based-remediation presubmit Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.23-tls-pqc-readiness medik8s/storage-based-remediation presubmit Ci-operator config changed

A total of 98 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@razo7

razo7 commented Aug 21, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2026
@razo7

razo7 commented Aug 21, 2026

Copy link
Copy Markdown
Member

IMHO, there is no need to save resources here with a draft mode @abrugaro

@abrugaro
abrugaro marked this pull request as ready for review August 21, 2026 14:58
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2026
@openshift-ci
openshift-ci Bot requested review from clobrano and eemcmullan August 21, 2026 14:59
@abrugaro

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.22-openshift-e2e pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-aws-efs pull-ci-medik8s-self-node-remediation-main-4.22-openshift-e2e pull-ci-medik8s-machine-deletion-remediation-main-4.22-openshift-e2e pull-ci-medik8s-node-maintenance-operator-main-4.22-openshift-e2e

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@abrugaro: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants