Conversation
- Fix 404 documentation links for GCP OSD clusters where path slug changed from 'openshift_dedicated_clusters_on_gcp' to 'openshift_dedicated_clusters_on_google_cloud' - Fix 404 documentation links for ROSA HCP where path changed from 'install_rosa_with_hcp_clusters' to 'install_clusters' - Update anchor links in ROSA HCP templates to match current section IDs - Add missing 'https://' scheme in cluster_alerting_with_no_sre_access.json
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: judexzhu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe changes update documentation references in HCP and OSD notification definitions. The updates use current installation paths, Google Cloud paths, relevant anchors, and fully qualified HTTPS URLs. ChangesDocumentation reference updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This PR updates documentation links only, and the reviewed references are valid, so it is ready to merge. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@judexzhu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
bug
What this PR does / why we need it:
Fixes 404 documentation links identified across service log templates:
openshift_dedicated_clusters_on_gcptoopenshift_dedicated_clusters_on_google_cloud. Updated in:osd/Multiple_OCPBUGs_install_failure.jsonosd/OCPBUG_install_failure.jsonosd/rosa_cluster_cannot_be_recovered.jsoninstall_rosa_with_hcp_clusterstoinstall_clusters. Updated in:hcp/customer_cni_misconfiguration.jsonhcp/hcp_aws_kms_permissions_issue.json(both description and doc_references, plus updated section anchor)hcp/sts_operator_role_misconfigured.json(plus updated section anchors)https://prefix inosd/cluster_alerting_with_no_sre_access.json.Which Jira/Github issue(s) this PR fixes:
N/A
Special notes for your reviewer:
All links verified via
rhapi get-docandmake checklinks.Pre-checks:
make validatepassesmake checkseveritypassesmake checklinkspassesSummary by CodeRabbit