Skip to content

Boilerplate: Update to d0a07945463759cf0e3489cb46737dae08d66713 - #632

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
redhat-chai-bot:boilerplate-update-1-d0a07945463759cf0e3489cb46737dae08d66713
Sep 8, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
redhat-chai-bot:boilerplate-update-1-d0a07945463759cf0e3489cb46737dae08d66713

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Conventions:

  • openshift/golang-osd-e2e: Update

openshift/boilerplate@a8a3172...d0a0794

commit: 10c6c2336ba6c6a2895531dd483a2f63d6e868e1
author: red-hat-konflux[bot]
chore(deps): update konflux references


AI-generated. Review for accuracy.

Automated by scheduled task rosa_sre_boilerplate_update (instructions: ship_help_bot/shared/instructions/scheduled/rosa_sre_boilerplate_update.md, run: 69a806ae, commit: 20a4c3bc-dirty)

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of rate-limit responses when no valid retry timing is provided.
    • The system now returns to retry processing immediately instead of waiting for a default delay.

Conventions:
- openshift/golang-osd-e2e: Update
---
openshift/boilerplate@a8a3172...d0a0794

commit: 10c6c2336ba6c6a2895531dd483a2f63d6e868e1
author: red-hat-konflux[bot]
chore(deps): update konflux references

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 317229cb-15ec-46ea-8a32-d0525bbdf255

📥 Commits

Reviewing files that changed from the base of the PR and between d5ff1c2 and a6dfafa.

⛔ Files ignored due to path filters (2)
  • boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-e2e/gangway-bridge-template.yml is excluded by !boilerplate/**
📒 Files selected for processing (1)
  • test/e2e/gangway-bridge-template.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The retry script now logs HTTP 429 responses with invalid or missing Retry-After headers and continues through the normal retry logic without a 60-second sleep.

Changes

Retry-After handling

Layer / File(s) Summary
Invalid Retry-After retry behavior
test/e2e/gangway-bridge-template.yml
The invalid or missing Retry-After path no longer sleeps for 60 seconds or sets RATE_LIMITED_WAITED. It logs the condition and returns to normal retry backoff.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a6dfa

Invalid or missing Retry-After values now use normal retry backoff rather than a fixed 60-second wait. No merge-blocking risk is identified.

Suggested reviewers: dustman9000

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies a boilerplate update and names the target commit. It matches the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only shell retry handling in two YAML templates and updates the boilerplate commit marker. The exact diff adds no Ginkgo It, Describe, Context, or When test title. The…
Test Structure And Quality ✅ Passed PASS. The pull request changes only the embedded Bash retry handling in test/e2e/gangway-bridge-template.yml and its boilerplate copy. The changed files contain no Ginkgo or Gomega test constructs, …
Microshift Test Compatibility ✅ Passed The check is not applicable. The pull request changes only boilerplate metadata and Gangway shell-template retry logic. The committed diff adds no Ginkgo tests or test declarations such as It, `Desc…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only boilerplate metadata and Gangway YAML templates. The diff adds no Ginkgo tests or declarations such as It(), Describe(), Context(), or When(). Therefore, the SNO mu…
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only HTTP 429 retry handling in a Job template and its boilerplate source. The diff removes a 60-second sleep and a state assignment, then updates a log message. It adds no af…
Ote Binary Stdout Contract ✅ Passed PASS — The pull request changes only two YAML templates and a boilerplate commit marker. It does not change OTE Go entry points, RunSpecs setup, or suite hooks. The changed shell template logs with …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only retry handling in two generated YAML templates and updates the boilerplate commit marker. It adds no Ginkgo test declarations, IPv4 assumptions, or connectivity tar…
No-Weak-Crypto ✅ Passed The pull request changes only HTTP 429 retry handling in two synchronized YAML templates and updates a boilerplate commit reference. The added code logs an invalid Retry-After condition and returns …
Container-Privileges ✅ Passed The pull request changes only retry logging and backoff behavior in two copies of the Gangway Job manifest. The diff adds no privileged settings, hostPID, hostNetwork, hostIPC, SYS_ADMIN capability, r…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes the 429 branch to log only the static message Rate limited (429) — no valid Retry-After header. It removes the default sleep and flag assignment. The added log does no…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@samanthajayasinghe

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2026
@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redhat-chai-bot, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit aacfe4e into openshift:master Sep 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants