-
Notifications
You must be signed in to change notification settings - Fork 24
HYPERFLEET-538 - feat: CEL-based condition mapping engine #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tirthct
wants to merge
23
commits into
openshift-hyperfleet:main
Choose a base branch
from
tirthct:HYPERFLEET-538
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
339e519
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele 429fe8f
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele d584656
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele 6f443d4
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele 8257e71
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele 5401138
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele 1f87706
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele a822121
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele 5e5b32a
HYPERFLEET-538 - feat: CEL-based condition mapping engine
ldornele 3d1ab44
HYPERFLEET-538 - refactor: address code review feedback
ldornele 0578f42
HYPERFLEET-538 - fix: enforce CEL error rollback per design doc
ldornele 4bfb65e
HYPERFLEET-538 - fix: add missing db.MarkForRollback on CEL error
ldornele 8360794
HYPERFLEET-538 - fix: move Gomega assertion out of goroutine
ldornele 1defeaf
HYPERFLEET-538 - fix: propagate field validation error instead of sil…
ldornele 83d78b5
HYPERFLEET-538 - fix: address code review feedback
ldornele f7ea5d8
HYPERFLEET-538 - perf: avoid map allocation when hasUnknown=true
ldornele edb36d4
HYPERFLEET-538 - test: add coverage for reason/message expression errors
ldornele e57c438
HYPERFLEET-538 - feat: remove redundant tags, fix review comments
tirthct 2e2dde0
HYPERFLEET-538 - feat: remaining small fix
tirthct 65392fc
HYPERFLEET-538 - feat: fix coderabbit suggestions
tirthct 80f4d84
HYPERFLEET-538 - feat: fix coderabbit and Dmitrii's suggestions
tirthct 5e6cbb0
HYPERFLEET-538 - feat: fix linter
tirthct 6049b2c
HYPERFLEET-538 - feat: skip message and fix coderabbit comment
tirthct File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.