Conversation
odrcore 6.10.0. A password protected .doc, .ppt or .xls now reports itself as such, and since no password opens one, the reader says so rather than asking or handing the file to the web view. The rest comes with the core: PDF text copies as words, marking it highlights them, a few more PDFs open, and a repeating table header keeps its rows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Jjxr44wSfKMQegPbPBbVv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
odrcore 6.9.0 → 6.10.0.
Wired: an encrypted
.doc,.pptor.xlsnow reports itself encrypted.No password opens one — odrcore cannot decrypt them — so the reader says the
file is password protected instead of putting a prompt up that would only come
back, and instead of falling back to the web view, which makes nothing of it
either. Covered by a new test against the real encrypted fixture.
Comes with the core, nothing to wire: PDF text copies as words rather than
L o r e m, marking it highlights the words, PDFs with nested parentheses in astring open, and an odf table keeps the rows a repeating header holds.
Not wired: the new fit
6.10.0 adds
HtmlConfig::viewport_widthand anodr.setZoom()API, aimed atapps that know their web view's width. Both work by putting
zoomon the body,and that does not hold up in WKWebView: the zoom is applied to the layout, but
getBoundingClientRect()ignores it whileelementFromPoint()does not.Measured on the iOS 26 simulator with the page fitted at
zoom: 0.472:documentElement.clientWidthdocumentElement.scrollWidthbody.getBoundingClientRect().widthelementFromPointat the rect's centreelementFromPointat that point × the zoomSo the page fits and looks right, but everything that mixes rects with viewport
coordinates is off by the zoom factor — the app's tap-to-edit (its test fails),
and odrcore's own reading-position anchor, which is
elementFromPointplusgetBoundingClientRect. That machinery was verified in Chrome, where the twoagree.
The app therefore keeps fitting through the viewport meta tag, as before. Worth
a core-side issue:
getBoundingClientRect()needs dividing by the applied zoomwhere the engine reports unzoomed rects, or the fit needs to be a transform
rather than
zoom.Checks
over.
scripts/format.sh --checkclean.🤖 Generated with Claude Code