Give the edit button a place of its own - #622
Open
andiwand wants to merge 1 commit into
Open
Conversation
Edit was a toolbar pencil until 4.13 and became the fifth of nine rows behind the unfolding button in 4.14. A reader on F-Droid 4.16.0 wrote in asking where it had gone, having found neither the row nor a keyboard. DocumentActions now takes a list of standing actions rather than one primary, and DocumentFragment puts Edit above Search in it. Above, so the button nearest the thumb is Search whatever is open - Edit is only offered where the core can write the document back. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oSBf26h2baTaQsdEvpM5F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reader on F-Droid 4.16.0 wrote in: they had been editing LibreOffice documents for a while, and now found "keine Tastatur, keine Option, den Edit-Modus zu aktivieren".
Nothing is broken. I built
assembleFossDebugatv4.16.0and opened an.odt: "Edit document" is there and works, keyboard and all. It is just very hard to find. Until 4.13 it was a pencil in the toolbar withshowAsAction="always"; since the redesign in 4.14 it is the fifth of nine rows behind the unlabeled ⋮ button, below three rows that are all about how the page looks — so the fold-out reads as a display menu, and the pencil is four rows past where anyone stops looking.So the pencil gets a standing button again.
DocumentActions.setActionsnow takes a list of standing actions instead of one primary, andDocumentFragmentpasseslistOfNotNull(edit, search).Edit above Search, not below. Search is offered for every document and Edit only where the core writes the format back, so this order keeps the button nearest the thumb the same one whatever is open. A PDF simply has one fewer button, and Search does not move.
Also: the standing buttons get a tooltip, since they have no label plate beside them.
testODTnow asserts the button is displayed without unfolding anything, which is the whole point of the change;testPDFstill asserts it does not exist. Both match on content description now that the standing button has no label text. Verified on a Pixel 9 Pro API 36 emulator: both tests pass, and one tap on the pencil goes straight into edit mode.🤖 Generated with Claude Code
https://claude.ai/code/session_015oSBf26h2baTaQsdEvpM5F