fix(test): replace testify with gomega in controller suite (#143) - #164
Open
MrBeldum wants to merge 1 commit into
Open
fix(test): replace testify with gomega in controller suite (#143)#164MrBeldum wants to merge 1 commit into
MrBeldum wants to merge 1 commit into
Conversation
Remove the sole direct testify usage so testify can leave go.mod. Matches the gomega-based assertion suggested in opendefensecloud#143. Fixes opendefensecloud#143
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the only direct
testify/requirecall ininternal/controller/suite_test.gowith a gomegaNewWithT(t)assertion and dropsgithub.com/stretchr/testifyfromgo.mod.Fixes #143
Test plan
go test ./internal/controller/ -ccompilesgo.mod/go.sumno longer list testify