WIP - Remove from s3 - #305
Open
AlbertoCasasOrtiz wants to merge 7 commits into
Open
Conversation
Member
Author
|
I marked as WIP not because it is not finished, but to avoid anyone from merging this without extensive and comprehensive testing. Once we are sure, I will remove the WIP. |
Member
Author
|
@carmichaelong I added a first attempt of testing for S3 removal. Instead of individually testing each receiver, what I did is mock the removal of sessions, trials or results, so the tests behave closer to what actually happens in production. Let me know your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented pre-delete signals to remove elements from S3. Implemented as signals as it handles both single row delete and bulk delete.