Dequeue atomic - #290
Open
AlbertoCasasOrtiz wants to merge 8 commits into
Open
Conversation
Member
Author
|
@carmichaelong I just fixed conflicts on this branch |
csherry04
reviewed
Aug 7, 2026
Comment on lines
1667
to
1703
There was a problem hiding this comment.
@AlbertoCasasOrtiz It looks like maybe this second section got copied in with merge but it reassigning the things just assigned in the atomic transaction. The second version (not atomic) seems to maybe be the one with updated logic for the delayed uploads? Perhaps then can get rid of the first one and wrap the second one in an atomic transaction?
Member
Author
There was a problem hiding this comment.
Thank you @csherry04. I just updated it accordingly (to avoid conflicts with dev and duplicated code, I modified from original code again to be atomic).
Member
Author
|
I just created a new test for this. Also, changed some database calls to be more efficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #267.
Most changes are due to indentation. Real changes are the addition of atomic to make everything a single transaction:
Select for update, which locks the trial so other workers cannot modify or lock them. If already locked by another worker, it skips it.
And a status check that, if for any reason a worker gets a trial already locked and in a non-available status, will skip it: