build(deps): upgrade Kotlin declarations together to 2.2.21 - #1079
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 87 mixed files remain; 0 existing customizations changed. Compared 87 existing customizations unchanged
47 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36067563245 --repo openai/openai-java \
--name castiron-custom-code-36067563245-1 --dir /tmp/castiron-custom-code-36067563245-1
git apply --stat /tmp/castiron-custom-code-36067563245-1/custom-code.patch
cat /tmp/castiron-custom-code-36067563245-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 2cbf22ca192670619bce0f04761813b814b758d5 eb1859da94ff8e1f44ea7125641231f476dba211
python3 scripts/castiron/custom_code_report.py report \
--base 2cbf22ca192670619bce0f04761813b814b758d5 \
--head eb1859da94ff8e1f44ea7125641231f476dba211 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-eb1859da94ff
cat /tmp/castiron-custom-code-eb1859da94ff/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed eb1859da94ff8e1f44ea7125641231f476dba211; no blocking findings.
The complete diff changes only the two Kotlin version values in buildSrc/build.gradle.kts, keeping the build plugin and convention-plugin dependency aligned. Eight independent source/base checks confirm that the Java runtime floors, Kotlin language/API 1.8 settings, stdlib 1.8.0 setting, JVM-default mode, Gradle wrapper, and publication configuration are unchanged. Kotlin 2.2.21 includes Gradle 8.12 in its supported Gradle range, and language level 1.8 remains supported with a deprecation warning.
Verified exact-head CI run 36067469210: build, lint, tests, API compatibility, Jackson compatibility, and Java 8/25 consumer probes passed. The logs confirm actual build-logic tests, ProGuard/R8 tests, and all four Java 8 artifact probes executed. The embedded-Kotlin and language-level warnings are present but did not fail those checks. I did not independently rerun Gradle or regenerate the Maven POMs locally; no source changes or review scratch files were created.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed eb1859d. Both Kotlin declarations move together to 2.2.21, while the SDK convention retains Kotlin language/API 1.8, stdlib 1.8.0 and the Java 8 target/release policy. The selected compiler supports the pinned Gradle 8.12; no actionable compatibility or structural issue found in this two-line change.
Source-only review; no local workloads run. Exact-head hosted build, lint, Jackson compatibility, Java 8/25 runtime checks and the required CI gate passed. The embedded-Kotlin mismatch and language-level deprecation warnings remain known caveats; generated POMs/artifacts were not independently inspected.
Automated Release PR --- ## [4.69.3](openai/openai-java@v4.69.2...v4.69.3) (2026-09-25) ### Chores * **api:** document files and uploads error responses ([openai#1081](openai#1081)) ([69a4e21](openai@69a4e21)) * **api:** document Responses not-found errors ([openai#1080](openai#1080)) ([e8cbf5d](openai@e8cbf5d)) ### Build System * **deps:** bump Maven Publish to 0.34.0 ([openai#910](openai#910)) ([2cbf22c](openai@2cbf22c)) * **deps:** bump Shadow to 9.2.2 ([openai#904](openai#904)) ([09b8c60](openai@09b8c60)) * **deps:** upgrade Kotlin declarations together to 2.2.21 ([openai#1079](openai#1079)) ([465742d](openai@465742d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
3 participants
Summary
Upgrade both Kotlin build declarations together from 1.9.20 to 2.2.21.
Supersedes #909 and #930. Their separate 2.4.10 bumps leave the declarations mismatched and do not support the SDK's pinned Kotlin 1.8 language level. Kotlin 2.2.21 supports the existing Gradle 8.12 and Kotlin 1.8 language/API settings.
The diff changes only the two version declarations. Java runtime floors, Kotlin language/API 1.8, stdlib 1.8.0, and Gradle/Dokka/publishing configuration remain unchanged. Expected SDK release treatment: patch within the existing compatibility contract.
Validation
GitHub CI will additionally run mock-server tests and Java 8/25 runtime probes. Gradle emits an embedded-Kotlin version warning and Kotlin 1.8 deprecation warnings; the local validations above pass with those warnings. This is not a claim of security remediation.
References