Revert "fix(api)!: declare required local shell output call IDs (#1044)" - #1048
Merged
Merged
Conversation
This reverts commit 8d1aa39.
Contributor
Castiron custom code✅ No new custom-code files detected. 83 mixed files remain; 0 existing customizations changed; 1 generated baselines changed. Compared
82 existing customizations unchanged
42 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35626012005 --repo openai/openai-java \
--name castiron-custom-code-35626012005-1 --dir /tmp/castiron-custom-code-35626012005-1
git apply --stat /tmp/castiron-custom-code-35626012005-1/custom-code.patch
cat /tmp/castiron-custom-code-35626012005-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 8d1aa390a325d69b68dd4db060f5dfefb1385e81 6a505a8f01e339207d5714434547df509524d19d
python3 scripts/castiron/custom_code_report.py report \
--base 8d1aa390a325d69b68dd4db060f5dfefb1385e81 \
--head 6a505a8f01e339207d5714434547df509524d19d --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-6a505a8f01e3
cat /tmp/castiron-custom-code-6a505a8f01e3/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
marked this pull request as ready for review
September 21, 2026 16:06
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a505a8f01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dpiet-oai
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1044.
This reverts commit 8d1aa39.
The generated SDK changes merged before their source-of-truth changes. This restores the preceding SDK definitions and generation metadata. The resulting tracked tree exactly matches the reverted commit’s parent.
Validation: the complete patch is byte-for-byte the inverse of the named commit. Version manifests and release configuration are unchanged. Local test suites and new review rounds were not run for this urgent revert; current-head CI will validate this PR.
CI diagnosis: API compatibility fails on 15
callIdreferences in the external tests extracted from base8d1aa390a325d69b68dd4db060f5dfefb1385e81. Every failing reference was introduced by #1044. This revert's entire tracked tree equals pre-promotiond2969f8efd588e492d97ec41e892cd91e9906c59; the new API is deliberately absent. The required aggregate fails because this job fails.The existing workflow always executes the detector from the current PR base and imports that base's tests. It has no supported unreleased-revert baseline selection. Changing this PR's detector or fixtures cannot override that trusted check. An explicit repository policy for validating unreleased reverts against their verified pre-promotion baseline is needed to reconcile this check with the requested rollback. The gate remains failed; no API restoration, test exclusion, forced-success status, retry, or version bump was used.