Skip to content

fix(api): correct tool and tool-output schema tags - #1045

Closed
markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-131
Closed

fix(api): correct tool and tool-output schema tags#1045
markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-131

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Clarifies tool-output content tags and the apply-patch tool tag while preserving existing tool types.

Changes

  • Associates text, image and file tool outputs with their existing content variants.
  • Associates apply_patch with its existing tool schema in the stable and Beta API references.
  • Preserves existing tool type names and constructors.

Source monorepo PR: #1533883.

@github-actions

github-actions Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

83 mixed files remain; 0 existing customizations changed.

Compared d2969f8efd58 → c6bde9371da3. Generated baselines verified.

83 existing customizations unchanged
  • openai-java-core/src/main/kotlin/com/openai/models/audio/AudioResponseFormat.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuth.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthCreateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthRotateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionMessageFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionToolMessageParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/Embedding.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/EmbeddingCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionWebSearch.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseInputItem.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseTextConfig.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/Video.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/UnwrapWebhookEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/WebhookEndpointWithSecret.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/audio/TranscriptionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/beta/agents/SessionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/beta/agents/SessionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/chat/ChatCompletionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/finetuning/checkpoints/PermissionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/ResponseService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/ResponseServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/WebhookService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/WebhookServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/audio/TranscriptionServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/beta/agents/SessionService.kt

43 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35576506827 --repo openai/openai-java \
  --name castiron-custom-code-35576506827-1 --dir /tmp/castiron-custom-code-35576506827-1
git apply --stat /tmp/castiron-custom-code-35576506827-1/custom-code.patch
cat /tmp/castiron-custom-code-35576506827-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin d2969f8efd588e492d97ec41e892cd91e9906c59 c6bde9371da35864d087b1f2ed6cc02bc649a80d
python3 scripts/castiron/custom_code_report.py report \
  --base d2969f8efd588e492d97ec41e892cd91e9906c59 \
  --head c6bde9371da35864d087b1f2ed6cc02bc649a80d --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-c6bde9371da3
cat /tmp/castiron-custom-code-c6bde9371da3/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 21, 2026 05:59
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 21, 2026 05:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T08:12:27.633398Z c6bde93 New commits
🔒 Security Review ✅ Completed 2026-09-21T08:13:36.375003Z c6bde93 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 18.14s for Java SDK PR #1045.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 793ms
tests/chat-completions-create.test.ts ✅ Passed 833ms
tests/chat-completions-stream.test.ts ✅ Passed 623ms
tests/files-content-binary.test.ts ✅ Passed 353ms
tests/files-create-multipart.test.ts ✅ Passed 362ms
tests/files-list-pagination.test.ts ✅ Passed 301ms
tests/initialize-config.test.ts ✅ Passed 226ms
tests/instance-isolation.test.ts ✅ Passed 178ms
tests/models-list.test.ts ✅ Passed 207ms
tests/responses-background-lifecycle.test.ts ✅ Passed 276ms
tests/responses-body-method-errors.test.ts ✅ Passed 567ms
tests/responses-cancel-timeout.test.ts ✅ Passed 222ms
tests/responses-cancel.test.ts ✅ Passed 559ms
tests/responses-compact-retries.test.ts ✅ Passed 348ms
tests/responses-compact.test.ts ✅ Passed 313ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 823ms
tests/responses-create-advanced.test.ts ✅ Passed 1.599s
tests/responses-create-disconnect.test.ts ✅ Passed 1.103s
tests/responses-create-errors.test.ts ✅ Passed 390ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 275ms
tests/responses-create-retries.test.ts ✅ Passed 276ms
tests/responses-create-stream-failures.test.ts ✅ Passed 358ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 323ms
tests/responses-create-stream-wire.test.ts ✅ Passed 6.827s
tests/responses-create-stream.test.ts ✅ Passed 95ms
tests/responses-create-terminal-states.test.ts ✅ Passed 423ms
tests/responses-create-timeout.test.ts ✅ Passed 265ms
tests/responses-create.test.ts ✅ Passed 268ms
tests/responses-delete.test.ts ✅ Passed 317ms
tests/responses-input-items-errors.test.ts ✅ Passed 323ms
tests/responses-input-items-list.test.ts ✅ Passed 324ms
tests/responses-input-items-options.test.ts ✅ Passed 462ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 311ms
tests/responses-input-tokens-count.test.ts ✅ Passed 336ms
tests/responses-malformed-inputs.test.ts ✅ Passed 5.595s
tests/responses-not-found-errors.test.ts ✅ Passed 443ms
tests/responses-parse.test.ts ✅ Passed 752ms
tests/responses-retrieve-retries.test.ts ✅ Passed 903ms
tests/responses-retrieve.test.ts ✅ Passed 346ms
tests/responses-stored-method-errors.test.ts ✅ Passed 1.03s
tests/retry-behavior.test.ts ✅ Passed 3.507s
tests/sdk-error-shape.test.ts ✅ Passed 457ms

View OkTest run #35576439009

SDK merge (fadfc6d4511b) · head (c6bde9371da3) · base (d2969f8efd58) · OkTest (a0be4375e02d)

@markstuart-oai
fix(api): correct tool and tool-output schema tags
c6bde93 
Castiron-Internal-PR: openai/openai-java-internal#131
Castiron-Source-SHA: 28eae308dfbc59de58adfe13749341bb79db1d77
Castiron-Public-Base-SHA: d2969f8
@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-131 branch from 2aa1e6b to c6bde93 Compare September 21, 2026 08:09
@markstuart-oai markstuart-oai changed the title fix(api): correct tool output content schema tags fix(api): correct tool and tool-output schema tags Sep 21, 2026
@markstuart-oai
markstuart-oai marked this pull request as draft September 22, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpiet-oai dpiet-oai dpiet-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markstuart-oai @dpiet-oai