Skip to content

chore(api): clarify computer call output identifiers - #1043

Open
markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-129
Open

markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-129

Conversation

@markstuart-oai

Copy link
Copy Markdown
Contributor

Summary

Clarifies stable and beta computer call output ID documentation.

Changes

  • Preserves required returned IDs and status, with optional IDs on input.

Castiron-Internal-PR: openai/openai-java-internal#129
Castiron-Source-SHA: 4c3c086df5e1363e3aa2e44e27e4e036595e6652
Castiron-Public-Base-SHA: d2969f8
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

83 mixed files remain; 0 existing customizations changed.

Compared d2969f8efd5853ea481cc635. Generated baselines verified.

83 existing customizations unchanged
  • openai-java-core/src/main/kotlin/com/openai/models/audio/AudioResponseFormat.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuth.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthCreateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthRotateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionMessageFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionToolMessageParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/Embedding.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/EmbeddingCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionWebSearch.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseInputItem.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseTextConfig.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/Video.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/UnwrapWebhookEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/WebhookEndpointWithSecret.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/audio/TranscriptionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/beta/agents/SessionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/beta/agents/SessionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/chat/ChatCompletionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/finetuning/checkpoints/PermissionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/ResponseService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/ResponseServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/WebhookService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/WebhookServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/audio/TranscriptionServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/beta/agents/SessionService.kt

43 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35560809957 --repo openai/openai-java \
  --name castiron-custom-code-35560809957-1 --dir /tmp/castiron-custom-code-35560809957-1
git apply --stat /tmp/castiron-custom-code-35560809957-1/custom-code.patch
cat /tmp/castiron-custom-code-35560809957-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin d2969f8efd588e492d97ec41e892cd91e9906c59 53ea481cc63562641d794dff35575f936d464329
python3 scripts/castiron/custom_code_report.py report \
  --base d2969f8efd588e492d97ec41e892cd91e9906c59 \
  --head 53ea481cc63562641d794dff35575f936d464329 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-53ea481cc635
cat /tmp/castiron-custom-code-53ea481cc635/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 21, 2026 04:23
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 21, 2026 04:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T04:24:24.458869Z 53ea481 Draft marked ready
🔒 Security Review Completed 2026-09-21T04:25:17.022582Z 53ea481 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

236/236 SDK tests passed in 15.826s for Java SDK PR #1043.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 526ms
tests/chat-completions-create.test.ts ✅ Passed 623ms
tests/chat-completions-stream.test.ts ✅ Passed 344ms
tests/files-content-binary.test.ts ✅ Passed 217ms
tests/files-create-multipart.test.ts ✅ Passed 324ms
tests/files-list-pagination.test.ts ✅ Passed 266ms
tests/initialize-config.test.ts ✅ Passed 215ms
tests/instance-isolation.test.ts ✅ Passed 225ms
tests/models-list.test.ts ✅ Passed 291ms
tests/responses-background-lifecycle.test.ts ✅ Passed 194ms
tests/responses-body-method-errors.test.ts ✅ Passed 556ms
tests/responses-cancel-timeout.test.ts ✅ Passed 199ms
tests/responses-cancel.test.ts ✅ Passed 233ms
tests/responses-compact-retries.test.ts ✅ Passed 384ms
tests/responses-compact.test.ts ✅ Passed 263ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 325ms
tests/responses-create-advanced.test.ts ✅ Passed 1.183s
tests/responses-create-disconnect.test.ts ✅ Passed 1.032s
tests/responses-create-errors.test.ts ✅ Passed 281ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 311ms
tests/responses-create-retries.test.ts ✅ Passed 267ms
tests/responses-create-stream-failures.test.ts ✅ Passed 1.322s
tests/responses-create-stream-timeout.test.ts ✅ Passed 230ms
tests/responses-create-stream-wire.test.ts ✅ Passed 5.824s
tests/responses-create-stream.test.ts ✅ Passed 193ms
tests/responses-create-terminal-states.test.ts ✅ Passed 306ms
tests/responses-create-timeout.test.ts ✅ Passed 221ms
tests/responses-create.test.ts ✅ Passed 364ms
tests/responses-delete.test.ts ✅ Passed 211ms
tests/responses-input-items-errors.test.ts ✅ Passed 320ms
tests/responses-input-items-list.test.ts ✅ Passed 292ms
tests/responses-input-items-options.test.ts ✅ Passed 204ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 270ms
tests/responses-input-tokens-count.test.ts ✅ Passed 233ms
tests/responses-malformed-inputs.test.ts ✅ Passed 4.699s
tests/responses-not-found-errors.test.ts ✅ Passed 488ms
tests/responses-parse.test.ts ✅ Passed 544ms
tests/responses-retrieve-retries.test.ts ✅ Passed 292ms
tests/responses-retrieve.test.ts ✅ Passed 273ms
tests/responses-stored-method-errors.test.ts ✅ Passed 997ms
tests/retry-behavior.test.ts ✅ Passed 3.581s
tests/sdk-error-shape.test.ts ✅ Passed 431ms

View OkTest run #35560786295

SDK merge (0afd5db5c6af) · head (53ea481cc635) · base (d2969f8efd58) · OkTest (a0be4375e02d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants