chore(api): clarify image fidelity and legacy image guidance - #1042
Open
markstuart-oai wants to merge 1 commit into
Open
markstuart-oai wants to merge 1 commit into
markstuart-oai wants to merge 1 commit into
Conversation
Contributor
Castiron custom code✅ No new custom-code files detected. 83 mixed files remain; 0 existing customizations changed. Compared 83 existing customizations unchanged
43 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35566994776 --repo openai/openai-java \
--name castiron-custom-code-35566994776-1 --dir /tmp/castiron-custom-code-35566994776-1
git apply --stat /tmp/castiron-custom-code-35566994776-1/custom-code.patch
cat /tmp/castiron-custom-code-35566994776-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin d2969f8efd588e492d97ec41e892cd91e9906c59 d1c81db1bcf278607edf4348ca47b9f634c36765
python3 scripts/castiron/custom_code_report.py report \
--base d2969f8efd588e492d97ec41e892cd91e9906c59 \
--head d1c81db1bcf278607edf4348ca47b9f634c36765 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-d1c81db1bcf2
cat /tmp/castiron-custom-code-d1c81db1bcf2/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
marked this pull request as ready for review
September 21, 2026 04:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
dpiet-oai
approved these changes
Sep 21, 2026
Castiron-Internal-PR: openai/openai-java-internal#128 Castiron-Source-SHA: de26a0dcfe5885842d003049d8f9e99b85ce5cdd Castiron-Public-Base-SHA: d2969f8
markstuart-oai
force-pushed
the
castiron/promotions/pr-128
branch
from
September 21, 2026 06:04
f1434f8 to
d1c81db
Compare
dpiet-oai
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies model-specific image fidelity guidance and labels retired DALL·E settings as legacy. The low default applies to supporting models; mini retains its low-only exception, and unsupported models require omission. Supported image workflows use an explicit model choice.
No runtime behavior, request types, enums, defaults, nullability or serialization change.