Conversation
Castiron-Internal-PR: openai/openai-java-internal#91 Castiron-Source-SHA: d46de9fe1b206fffacca70127ecc634326f732d7 Castiron-Public-Base-SHA: a363812
Castiron custom code✅ No new custom-code files detected. 83 mixed files remain; 0 existing customizations changed. Compared 83 existing customizations unchanged
43 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35483794037 --repo openai/openai-java \
--name castiron-custom-code-35483794037-1 --dir /tmp/castiron-custom-code-35483794037-1
git apply --stat /tmp/castiron-custom-code-35483794037-1/custom-code.patch
cat /tmp/castiron-custom-code-35483794037-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin a363812216605acd7ee60a1f5ca986e4905e0195 10fcc9e5724b8e0712b2b63745c121b0b8987f95
python3 scripts/castiron/custom_code_report.py report \
--base a363812216605acd7ee60a1f5ca986e4905e0195 \
--head 10fcc9e5724b8e0712b2b63745c121b0b8987f95 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-10fcc9e5724b
cat /tmp/castiron-custom-code-10fcc9e5724b/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed all three changed files at 10fcc9e5724b8e0712b2b63745c121b0b8987f95. No blocking correctness or structural findings. The guard belongs in the OkHttp adapter: it uses the selected proxy and transport handshake to reject TLS-origin 407s, including application CONNECT requests, while retaining HTTP-proxy and pre-TLS CONNECT authentication.
I checked those distinctions against the pinned OkHttp 4.12.0 implementation and verified successful CI, including the OkHttp module's test task. The five new tests exercise synthetic authenticator responses; this review did not run a live proxy/TLS exchange.
Proxy credentials could be attached to an HTTPS origin response posing as a proxy challenge, including a CONNECT request sent inside an established TLS tunnel. Require an HTTP proxy route and reject TLS-origin responses while preserving HTTP proxy and tunnel authentication.
Validation: five proxy-authenticator boundary cases pass, including the TLS CONNECT regression, plus Kotlin formatting and lint. Tests use synthetic authenticator responses; they do not establish a live proxy tunnel.