fix(cli): use shell-neutral env-var removal guidance - #754
Merged
mldangelo-oai merged 1 commit intoAug 30, 2026
Merged
Conversation
login status and post-login warnings told users to run POSIX unset, which is invalid in PowerShell. Print shell-neutral wording instead.
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
mldangelo-oai
approved these changes
Aug 30, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing the PowerShell guidance. This makes the messages usable across shells while keeping authentication behavior unchanged. The tests cover both key names, mixed-case names, and the login and access-token warning paths.
I reviewed commit e488ee9ca1a165182b5fcb11582c3c250f407d32 and found no blocking issues. The 29 focused tests, type checking, formatting, and all CI checks passed. Codex's automated review attempt hit its usage quota, so this approval is based on my code review and those checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
login statusand the post-login warning printed POSIXunset OPENAI_API_KEY ..., which is invalid in PowerShell. Windows users following that hint cannot drop the environment API keys that shadow a ChatGPT sign-in.Fixes #33.
Changes
formatEnvironmentVariableRemovalGuidance()so the CLI prints shell-neutral wording (remove OPENAI_API_KEY and CODEX_API_KEY from the environment) instead of a POSIX command.login statuspath and the post-login / access-token warning that lists whichever shadowing keys are actually set.Testing
bun test --timeout 30000 ./tests-ts/api-environment.test.ts ./tests-ts/cli-authentication.test.ts— 29 pass, 0 failpnpm run lint(tsc --noEmit) — exit 0Risk and rollout
Documentation-only user-facing strings. No auth, scan, or credential-handling behavior change. Existing CLI authentication tests now assert the shell-neutral text and that
unsetno longer appears.Public disclosure review