Skip to content

test: verify native Node package behavior - #748

Open
mldangelo-oai wants to merge 4 commits into
mainfrom
mdangelo/codex/test-node-behavior-contracts
Open

test: verify native Node package behavior#748
mldangelo-oai wants to merge 4 commits into
mainfrom
mdangelo/codex/test-node-behavior-contracts

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

The installed-package checks cover entrypoints and worker startup, but the broader SDK lifecycle is tested primarily under Bun. Add native Node coverage to the existing package matrix for completion, cancellation, cleanup, and terminal output.

Changes

  • Run the installed SDK through a completed scan, an aborted scan, and closing an active scan. Check persisted outcomes, stream cleanup, runtime-home removal, and preservation of completed artifacts.
  • Control model output and runtime installation while keeping the real filesystem, Python workbench, SQLite, and finalizer. Reuse the bundled completed-scan example for synthetic artifacts.
  • Exercise the compiled CLI with a synthetic publication receipt. Check C1/ANSI cleanup, safe issue links, rejected credential-bearing URLs, and signal-listener cleanup. Include captured stderr when the command fails.
  • Reuse the existing package timeout and temporary-consumer cleanup. Assert cleanup immediately after closing the active scan.
  • Install Python in the container build stage for the workbench checks. The final runtime stage is unchanged.
  • Merge current main into the branch.

Testing

  • Built and packed the npm archive successfully.
  • Full installed-package checks passed under Node 22.13.0 and Node 24.15.0, including the new lifecycle and terminal contracts and existing NodeNext, CLI, credential-lock, MCP, and nested-worker checks.
  • Typechecking, generated-model checks, formatting, and git diff --check passed.

Risk and rollout

Test and build-stage change, run by the existing supported-Node package matrix. The contract does not call a live model or create external issues. It adds real workbench operations to each package check while leaving production behavior unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 30, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T06:43:41.347015Z 6670cc2 Manual request
🔒 Security Review Completed 2026-08-30T06:43:18.648740Z 6670cc2 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, 802fea5.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 802fea57ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, 3a44367.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 3a44367768

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, 6670cc2.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 6670cc2e86

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants