fix(multiscan): preserve scan outcome and record receipt when checkout cleanup fails - #740
Open
Ultron09 wants to merge 1 commit into
Open
fix(multiscan): preserve scan outcome and record receipt when checkout cleanup fails#740Ultron09 wants to merge 1 commit into
Ultron09 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve multiscan attempt outcomes and ensure attempt receipts are durably recorded in
results.jsonlwhen checkout directory removal encounters secondary filesystem errors (such asEACCES,EPERM, orEBUSY).Fixes #211.
Changes
sdk/typescript/src/multiscan.ts, decouple the checkout removal cleanup step from the primary scan outcome capture and receipt appending.completed,completed_with_incomplete_coverage, orfailed) in the ledger receipt, and emit a non-fatal warning on progress notifications.sdk/typescript/tests-ts/multiscan.test.ts, add regression tests verifying:Testing
bun test ./tests-ts/multiscan.test.ts(53 pass, 2 skip, 0 fail)pnpm --dir sdk/typescript run types(passed with 0 errors)pnpm --dir sdk/typescript run format(passed with all files formatted)python .github/scripts/check_plugin_source_compatibility.py(passed)Risk and rollout
Low. This change makes multiscan worker cleanup resilient without modifying the scan execution or ledger format contract.
Public disclosure review