fix(deep-scan): exclude unconsumed partial findings from successful results - #718
Open
msapelov wants to merge 1 commit into
Open
fix(deep-scan): exclude unconsumed partial findings from successful results#718msapelov wants to merge 1 commit into
msapelov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent incomplete artifacts from unconsumed Deep Scan discovery workers from adding unmatched top-level findings after a successful canonical reducer has completed.
Successful Deep Scan completion now keeps the reducer result authoritative while retaining stopped-scan loss recovery and represented worker evidence.
Fixes #717
Changes
merge_state == "merged"as the persisted signal that a discovery worker participated in the successful reducer lineage.Testing
pnpm run check:plugin-source: passed.pnpm run types: passed.pnpm run format: passed.pnpm run test:mcp: passed.pnpm pack: passed.git diff --check: passed.pnpm run test:ci: 2028 passed, 31 skipped, with 3 unrelated failures previously reproduced on the base.@openai/codex@0.149.1; package creation itself passed.Risk and rollout
The behavior change is limited to successful Deep Scan finalization when a valid canonical reducer result exists.
Reducer-consumed discovery artifacts retain their existing recovery behavior. Unconsumed artifacts remain preserved in saved-source metadata and may enrich represented findings, but cannot introduce unmatched top-level findings or coverage entries.
Failed, canceled, and interrupted parent scans retain the loss-preserving behavior introduced by #617. No schema migration or persisted-state change is required.
Public disclosure review