fix(publish): retain recovery guidance on canceled uploads - #680
fix(publish): retain recovery guidance on canceled uploads#680mldangelo-oai wants to merge 7 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e28127ab7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b04e0425e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex security review Please review current head f57a29a. The original fix in #677 is now merged, so this PR changes only CLI recovery presentation and tests. Request tracking now begins at the POST boundary and resets between batch entries. All 118 focused tests, typechecking, formatting, build, and real-signal CLI smoke tests pass. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review current head a0b95f6. The merge with main preserves both the Cloud fetch hook and the custom publication dependency. Please check cancellation recovery guidance and publication compatibility. Validation passed: 127 focused publication tests, plugin source checks, typechecking, formatting, build, package and installed-runtime checks, and built CLI smoke tests with real SIGINT and SIGTERM during requests and receipts. The full local suite and fresh platform CI are running. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review current head 90554d1. This adds the latest main and fixes the macOS CI race in the patch browser tests by flushing React updates after keyboard input instead of sleeping for 60 ms. The Cloud recovery implementation is unchanged from the previously reviewed head. All 136 combined publication and UI tests pass. The complete patch browser suite passed 225 checks across 25 repetitions using the failing CI seed, with no React synchronization warnings. Typechecking, formatting, and plugin source compatibility checks pass. The full local suite and fresh CI are running. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
Keep the caller's cancellation reason without losing Cloud upload recovery guidance. An interrupted upload may already have been accepted, so the CLI must still tell users to check Cloud before retrying.
Follow-up to merged #677. Its caller-cancellation change stays unchanged; this PR preserves the matching CLI recovery behavior.
Changes
SIGINTorSIGTERM.Testing
cloud-publish.test.ts,cli-cloud-publish.test.ts,cli-publish.test.ts, andpatch-tui.test.ts.SIGINTandSIGTERMduring both the request and receipt phases retained recovery guidance, exited with 130/143, and made only one POST.pnpm run check:plugin-source,pnpm run types,pnpm run format, andpnpm run build: passed.pnpm packandpnpm run check:package: passed. Verified 390 archive entries, installed imports and NodeNext types, CLI startup, credential locking, 122 bundled plugin files, MCP initialization, the bundled runtime, dashboard assets, and a nested worker without a global runtime installation.git diff --check: passed. Full platform verification is tracked in the PR checks.Risk and rollout
The production change is limited to cancellation propagation and error presentation. It adds no public flags, configuration, dependencies, or retry behavior. Cancellation still exits with 130 for
SIGINTand 143 forSIGTERM; confirmed receipts and unattempted batch entries are preserved. Picker, dry-run, and Linear cancellation behavior remain unchanged. The recovery message is conditional and does not claim that an upload was accepted. The CI fix changes test synchronization only.Public disclosure review