fix #343 - feat: enable netlify preview CI for feature branches - #360
Open
fantonangeli wants to merge 4 commits into
Conversation
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
✅ Deploy Preview for openworkflow-editor canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Netlify previews for PRs targeting feature branches by updating the netlify.toml build ignore logic to compute an appropriate git base reference for pnpm-based change detection.
Changes:
- Update Netlify
ignorescript to fetch either the PR synthetic merge ref (refs/pull/<id>/merge) or the deployed branch ref. - Replace the hard-coded
origin/maincomparison with a dynamically computedBASE_REFused bypnpmworkspace filtering.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #343
Action required
@ricardozanini
Description
Currently PRs against feature branches don't have the Netlify previews.
We need to update the configuration to enable them.
Motivation
Reviewing UI and UX changes is much easier when a live preview is available directly from the PR.
Proposed Implementation
netlify.tomlTests using my fork
main: main pr test fantonangeli/open-workflow-specification-editor#18feature/node-editing: feature/node-editing pr test 2 fantonangeli/open-workflow-specification-editor#20main: https://app.netlify.com/projects/serverlessworkflow-editor/deploys/6a8ecb762f480700088c7cf6feature/node-editing: https://app.netlify.com/projects/serverlessworkflow-editor/deploys/6a8ecd1da7ec8c00083b165a