fix(sdk): correct instrument name validation error message length - #5513
Open
theycallmeloki wants to merge 2 commits into
Open
fix(sdk): correct instrument name validation error message length#5513theycallmeloki wants to merge 2 commits into
theycallmeloki wants to merge 2 commits into
Conversation
Signed-off-by: Loki San <ogmiladyloki@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sdk): correct instrument name validation error message length
Fixes #5284
Both instrument name and unit validation failures raised the same message:
"Expected ASCII string of maximum length 63 characters but got {}". Per the
spec, names allow up to 255 characters (plus start-letter/character-set
rules), while units are limited to 63. The misleading message sent developers
debugging length when the real problem was an invalid character.
_ERROR_MESSAGEsplit into_NAME_ERROR_MESSAGE(255) and_UNIT_ERROR_MESSAGE(63), applied at all four raise sites (sync + asyncinstruments).
TestInstrumentValidationMessagescovering both messages.Note: two commenters expressed interest in this issue without opening a PR;
happy to coordinate if they're actively working on something related.