opentelemetry-sdk: unify logging force_flush timeout defaults to 10000ms - #5438
Open
avinab-neogy wants to merge 4 commits into
Open
opentelemetry-sdk: unify logging force_flush timeout defaults to 10000ms#5438avinab-neogy wants to merge 4 commits into
avinab-neogy wants to merge 4 commits into
Conversation
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
Contributor
Author
|
@xrmx @carlosalberto Bumping this! It's out of draft and ready for a review. I went with 10_000 to match metrics, but just let me know if you'd rather I align it to 30000 for traces instead and I'll push an update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5403
Aligns all
force_flushtimeout defaults in the logging SDK to a single value (10_000ms),matching the exporters (
LogRecordExporter,ConsoleLogRecordExporter,InMemoryLogExporter)and the OTLP log exporters, which already used
10_000. Previously the logging module split5×
30000/ 3×10_000across different processors/exporters.Also changes
BatchLogRecordProcessor.force_flushto requiretimeout_millis: intinstead ofaccepting
int | None, so its signature matches the abstractLogRecordProcessor.force_flushit implements — the rest of the hierarchy never accepted
None.Opened as draft: pending confirmation from @carlosalberto on whether
10_000(vs.30000,to match traces) is the right target value, and confirming logging-only scope.
Type of change
How Has This Been Tested?
pytest opentelemetry-sdk/tests/logs/ -q— 111 passed, no regressionsDoes This PR Require a Contrib Repo Change?
Checklist: