build: consume immutable FFTW dependency bundles - #3
Closed
galenlynch wants to merge 1 commit into
Closed
galenlynch wants to merge 1 commit into
galenlynch wants to merge 1 commit into
Conversation
galenlynch
force-pushed
the
consume-fftw-dependency-bundles
branch
from
September 8, 2026 23:06
243406a to
76bcf0a
Compare
Normal builds still use the divergent FFTW binaries committed to libs/, so the verified dependency release does not yet govern the libraries that OpenEphysFFTW links and redistributes. Resolve the platform bundle from the versioned release during configuration, validate its checksum sidecar, and retain extracted-root and local-archive overrides for offline builds. Package both precision runtimes with their license and provenance, then remove the superseded binary blobs.
galenlynch
force-pushed
the
consume-fftw-dependency-bundles
branch
from
September 8, 2026 23:17
76bcf0a to
1efb034
Compare
Collaborator
Author
|
#2 no longer requires this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second of two packaging PRs. It changes normal OpenEphysFFTW builds to consume the immutable FFTW 3.3.11 release produced by the first PR, then removes the superseded binaries from
libs/without rewriting Git history.Changes
The repository does not copy generated archive hashes into source. The release's immutable checksum sidecars remain the source of truth, while CMake performs the verification locally.
Merge prerequisite
Do not merge this PR until:
fftw-dependencies-3.3.11-1has been published successfully.Verification
CI must configure, build, and test OpenEphysFFTW on Linux, Windows, and macOS using the published bundles. An offline-cache test should also prove that builds do not require network access when the dependency archive is supplied locally.