Technical Onboarding brbu - #1428
Open
AarnorDeDardaliel wants to merge 5 commits into
Open
AarnorDeDardaliel wants to merge 5 commits into
AarnorDeDardaliel wants to merge 5 commits into
Conversation
|
|
AarnorDeDardaliel
force-pushed
the
19.0-estate-brbu
branch
from
September 16, 2026 09:01
3c9ac1f to
83b5212
Compare
leclerc-leo
reviewed
Sep 17, 2026
leclerc-leo
left a comment
leclerc-leo
left a comment
There was a problem hiding this comment.
👋 Great Work, dont forget to setup a linter (ruff + ruff.toml file in odoo/community repo)
You can check the ci/style too.
Comment on lines
+1
to
+6
|
|
||
| from . import estate_property | ||
| from . import estate_property_type | ||
| from . import estate_property_tag | ||
| from . import estate_property_offer | ||
|
|
There was a problem hiding this comment.
nitpick
Suggested change
| from . import estate_property | |
| from . import estate_property_type | |
| from . import estate_property_tag | |
| from . import estate_property_offer | |
| from . import estate_property | |
| from . import estate_property_type | |
| from . import estate_property_tag | |
| from . import estate_property_offer |
| @@ -0,0 +1,77 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
A relic from another era.
Suggested change
| # -*- coding: utf-8 -*- |
| def action_sold(self): | ||
| for record in self: | ||
| if record.state == "cancelled": | ||
| raise exceptions.UserError("A cancelled property cannot be sold !") |
There was a problem hiding this comment.
nitpick, translations
Suggested change
| raise exceptions.UserError("A cancelled property cannot be sold !") | |
| raise exceptions.UserError(_("A cancelled property cannot be sold !")) |
| [Master the Odoo web framework](https://www.odoo.com/documentation/latest/developer/tutorials/master_odoo_web_framework.html) | ||
| tutorial's solutions. For example, `17.0`, `17.0-discover-js-framework-solutions` and | ||
| `17.0-master-odoo-web-framework-solutions`. | ||
|
|
There was a problem hiding this comment.
dont forget to not push changes on generic files.
| ], | ||
| 'installable': True, | ||
| 'application': True, | ||
| 'author': 'brbu', |
There was a problem hiding this comment.
Suggested change
| 'author': 'brbu', | |
| 'author': 'Odoo S.A.', |
leclerc-leo
reviewed
Sep 17, 2026
| return True | ||
|
No newline at end of file |
||
|
|
||
| _positive_offer_price = models.Constraint( |
There was a problem hiding this comment.
try to keep the constraint bellow the field.
usually we do:
- fields
- constraints
- compute
- internal function
- action
- the rest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.