19.0 technical training coleo by coleo-odoo · Pull Request #1422 · odoo/tutorials

coleo-odoo · 2026-09-15T12:15:04Z

No description provided.

This added the folder estate with __init_.py and __manifest__.py with minimal configuration to add an estate application

robodoo · 2026-09-15T12:15:07Z

msho-odoo

Nice work 🔥
Well done on the commit messages format, just a nitpick you can ignore for now, that CLN tag is usually for heavy cleaning of the code base but usual small cleaning can have the IMP tag.

But it's worth to note that usually when you fix something after a review, no need to add a new commit, you can use git commit --amend which allows you to edit your commit message and also include your current staged changes to the same commit without making a new one.

Also left you some comments, and always remember to have your runbot checked when you push and make sure it's green :)

msho-odoo · 2026-09-15T13:08:10Z

@@ -0,0 +1,3 @@
+{


ops, I should't see that file :)
see how to avoid adding such environment files in git pushes

msho-odoo · 2026-09-15T13:09:02Z

+    bedrooms = fields.Integer()
+    living_area = fields.Integer()
+    facades = fields.Integer()
+    garage = fields.Boolean()


Good practice to have boolean fields on the form is_something or has_something so you might change this to has_garden and has_garage

msho-odoo · 2026-09-15T13:11:29Z

+    garden_orientation = fields.Selection(
+        string='Type',
+        selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')]
+    )


The styling is fine by me but when we have multiple values it's better to have them on separate files.

Suggested change

garden_orientation = fields.Selection(

string='Type',

selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')]

)

garden_orientation = fields.Selection(

string='Garden Orientation',

selection=[

('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West'),

]

)

nitpick: some teams might stick to single quotes being only on technical strings (the ones that the user don't see) and double quotes are for the strings that the user can see)
so for example the selection can be ('east', "East") instead of ('east', 'East') but some teams don't do this, they just stick to their own convention which is all single quotes (if possible) or all double quotes.
I see you are stick to single quotes, fine be me (though it's not always possible :) )

msho-odoo · 2026-09-15T13:15:00Z

@@ -0,0 +1,2 @@
+"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
+"estate.access_estate_property","access_estate_property","estate.model_estate_property","base.group_user",1,1,1,1


Always add new line at the end of files.
no need to add the estate., the file is already in that module.
no need to add the double quotes as well, you can remove them.
Also as an improvement you can make the id access_estate_property_user (I added _user at the end) in case you want to add another rule on the same module but for the _manager not the base user

msho-odoo · 2026-09-15T13:15:37Z

@@ -0,0 +1,12 @@
+{
+    'name': 'Real Estate',
+    'author': 'coleo',


author is usually Odoo S.A. :)

msho-odoo · 2026-09-15T14:35:17Z

@coleo-odoo just forgot to tell you, you can mention me here when you think the PR is ready for another review, typically, after each chapter :)

Chapter 5 of tutorials

coleo-odoo · 2026-09-15T15:16:58Z

@msho-odoo I think the PR is ready for review.
I finished Chapter 5. Sorry for the number of commits, I'll try to keep it to one per chapter.

msho-odoo

Thanks for the nice work 👍
Left you a couple of comments.

nitpick: I would stick the commit message to be estate: create... instead of estate: created... since it should make a whole sentence when it's concatenated with this commit will .... according to git guidlines

msho-odoo · 2026-09-16T07:59:40Z

-    date_availability = fields.Date()
+    date_availability = fields.Date(
+        copy=False, 
+        default=fields.Date.add(fields.Date.today(), months=3)


In this default the date will get valued when this is first imported and will not change later with each creation, you should use lambda function to fix this. Search the codebase for lambda functions used in the default values of fields and apply it here :)

msho-odoo · 2026-09-16T08:01:06Z

+            <menuitem id="estate_menu_action" action="estate_action" name="Properties"/>
+        </menuitem>
+    </menuitem>
+</odoo>


Always remember the EOF new line and Always remember to fix red runbot to be green before reviews :)

msho-odoo · 2026-09-16T08:01:39Z

@@ -0,0 +1,7 @@
+<odoo>
+    <menuitem id="estate_menu_root" name="Real Estate">
+        <menuitem id="estate_first_level_menu" name="Advertisements">


Better to make ids more descriptive so that they indicate what they are without having to read the definition

msho-odoo · 2026-09-16T08:01:52Z

-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
    </record>
 </odoo>


EOF line in ALL files please: and remember the red runbot is already guiding you to fix this stuff so please check it before the review :)

msho-odoo · 2026-09-16T08:02:36Z

+            ('sold', 'Sold'),
+            ('cancelled', 'Cancelled')
+        ],
+        default="new",


Stick to a convention about quotes :)

msho-odoo · 2026-09-16T08:04:36Z

+    'name': 'Real Estate',
+    'author': 'Odoo S.A.',
+    'license': 'LGPL-3',
+    'depends': [


nitpick: usually the depends list is written in one line since it's usually just small module names but no biggie

…ties

…and form

offer : compute date_deadline according to validity property : compute total_area according to garden_area and living_area compute best_price according to the best offer add on_change to has_garden filling or clearing fields accordingly

… and property

…ea and Garden Orientation

…rs and less than 90% of the expected price for the selling price

coleo-odoo · 2026-09-17T14:57:15Z

@msho-odoo The PR should be ready for review

coleo-odoo added 4 commits September 15, 2026 14:13

[ADD] estate: create estate application

4f2a153

This added the folder estate with __init_.py and __manifest__.py with minimal configuration to add an estate application

[IMP] estate: create a table property with name and description

d0e571a

[IMP] estate: create columns to the property table

9d3cf5b

[IMP] estate: set the column name and selling_price to not null

29a8dc5

coleo-odoo added 2 commits September 15, 2026 14:36

[CLN] estate: add a newline at the end of files

02a48ac

[IMP] estate: create access rights for users

c4b618c

msho-odoo requested changes Sep 15, 2026

View reviewed changes

coleo-odoo added 3 commits September 15, 2026 15:29

[IMP] estate: create a basic action view for property

4a114ec

[IMP] estate: applied different suggestions to improve code

b7e9a51

[IMP] estate: applied different suggestions to improve code

8c53531

[IMP] estate: created a menu, fields, attributes and view

9e1e2a7

Chapter 5 of tutorials

msho-odoo requested changes Sep 16, 2026

View reviewed changes

coleo-odoo added 4 commits September 16, 2026 12:33

[IMP] estate: create custom views for the list and form of the proper…

a8cc8f4

…ties

[IMP] estate: create tag, type and offer with their menu action,list …

f3b96af

…and form

[FIX] estate: fix a bug when there is no offer for a property

98ccc2f

coleo-odoo force-pushed the 19.0-technical-training-coleo branch from a2b4c84 to 98ccc2f Compare September 17, 2026 11:28

coleo-odoo added 3 commits September 17, 2026 15:12

[IMP] estate: create multiple action button to update states of offer…

1dbfe02

… and property

[FIX] estate: fix warning onchange about erasing the fields Garden Ar…

104ffa4

…ea and Garden Orientation

[IMP] estate: add constraint on prices fields to avoid negative numbe…

b0f493b

…rs and less than 90% of the expected price for the selling price

		@@ -0,0 +1,2 @@
		"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
		"estate.access_estate_property","access_estate_property","estate.model_estate_property","base.group_user",1,1,1,1 No newline at end of file

Conversation

coleo-odoo commented Sep 15, 2026

Uh oh!

robodoo commented Sep 15, 2026

Uh oh!

msho-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msho-odoo commented Sep 15, 2026

Uh oh!

coleo-odoo commented Sep 15, 2026

Uh oh!

msho-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coleo-odoo commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants