19.0 tutorial delje by Delvaux-Jean-Baptiste · Pull Request #1415 · odoo/tutorials

Delvaux-Jean-Baptiste · 2026-09-15T11:17:43Z

[REF] Updated branch name
[FIX] Added extra end of file line

robodoo · 2026-09-15T11:17:46Z

msho-odoo

@Delvaux-Jean-Baptiste
Nice job on the branch situation 🔥

For the commit message we write in a way that aligns with when this commit is merged it will .....
so you might change [IMP] estate: Added models to something like [IMP] estate: add estate property model or however you like to describe your changes :)
refer to Git Guidlines

but really nice job, well done 👍
also left some comments for you to check

msho-odoo · 2026-09-15T11:28:18Z

+    bedrooms= fields.Integer()
+    living_area= fields.Integer()
+    facades= fields.Integer()
+    garage= fields.Boolean()


Good practice to have boolean fields on the form is_something or has_something so you might change this to has_garden and has_garage

msho-odoo · 2026-09-15T11:30:33Z

+    facades= fields.Integer()
+    garage= fields.Boolean()
+    garden= fields.Boolean()
+    garden_orientation= fields.Selection(string='Type',


It's good, but it's better to commit to a convention and follow it all the way, so for example in this field you wrote the attribute string before ='Type' but you didn't do that in name field Char('Estate Name')

msho-odoo · 2026-09-15T11:35:34Z

+    garden_orientation= fields.Selection(string='Type',
+                                        selection=[('east', 'East'),
+                                                    ('west', 'West'),
+                                                    ('north', 'North'),
+                                                    ('south', 'South')
+                                                    ]
+                                        )


It's correct but we style it like this (see the suggestion).

nitpick: some teams might stick to single quotes being only on technical strings (the ones that the user don't see) and double quotes are for the strings that the user can see)
so for example the selection can be ('east', "East") instead of ('east', 'East') but some teams don't do this, they just stick to their own convention which is all single quotes (if possible) or all double quotes

Suggested change

garden_orientation= fields.Selection(string='Type',

selection=[('east', 'East'),

('west', 'West'),

('north', 'North'),

('south', 'South')

]

)

garden_orientation= fields.Selection(

string='Type',

selection=[

('east', 'East'),

('west', 'West'),

('north', 'North'),

('south', 'South'),

]

)

msho-odoo · 2026-09-15T11:38:00Z

+    _name = "estate_property"
+    _description = "The details of a property"
+
+    name= fields.Char('Estate Name', required= True)


We do spaces before and after the operator so it's name = fields not name= fields.
Better to check all style errors in your runbot and fix it :)
The log there provides a description for the reason of the error

[ADD] estate: add estate access for base users

msho-odoo · 2026-09-15T14:39:22Z

@Delvaux-Jean-Baptiste please mention me here when you think the PR is ready for another review, typically, after each chapter :)
Also remember to check the runbot for styling issues 😉

added fields and default values in fields of new estate [IMP] estate: updated gitignore to exclude vs config

Delvaux-Jean-Baptiste · 2026-09-15T15:19:30Z

@msho-odoo I believe I am ready for the last review of the day ;-)

[IMP] estate: Update List, Form and Search for cleaner display

msho-odoo

Thanks for the good work!

Regarding the commit message we use [ADD] for adding whole new modules, but in this case (adding some field, view or feature/logic) we use [IMP] tag (for improvement) which you will be using most of the time in your team :)

I also left you some comments to check and please Always remember to green your runbot before pinging of the review 😉

msho-odoo · 2026-09-16T08:59:04Z

-    expected_price = fields.Float(required = True)
-    selling_price = fields.Float()
-    bedrooms = fields.Integer()
+    date_availability = fields.Date(copy=False, default=fields.Date.today()+relativedelta(months=3))


directly valuating the fields.Date at default will work when imported but it will be stuck at this value, you should use lambda function. Search the codebase for it and let me know if you have any question :)

msho-odoo · 2026-09-16T09:00:12Z

+            />
+        </menuitem>
+    </menuitem>
+</odoo>


Please Always check your runbot and make sure it's not red :)
it should be telling you you are missing a new line on the EOF here :)

msho-odoo · 2026-09-16T09:01:28Z

+                <field string="Estate" name="name"/>
+                <field name="postcode"/>
+                <field name="bedrooms"/>
+                <field string="Living Area (sqm)" name="living_area"/>


nitpick: usually we have name attribute before string so other developers see right away what field you are referring to

msho-odoo · 2026-09-16T09:06:46Z

+                <field string="Living Area (sqm)" name="living_area"/>
+                <field name="facades"/>
+
+                <filter string="Available" name="available" domain="['|',('state', '=', 'New'), ('state', '=', 'offer_received')]"></filter>


The key you check on is 'new' not 'New'
This could be easier to read

Suggested change

<filter string="Available" name="available" domain="['|',('state', '=', 'New'), ('state', '=', 'offer_received')]"></filter>

<filter string="Available" name="available" domain="[('state', 'in', ('new', 'offer_received'))]"></filter>

msho-odoo · 2026-09-16T09:07:53Z

+<!-- 
+    <record id="[ID given to this record]" model="[Model being modified]">
+        <field name="name">[name for this field]</field>
+        <field name="model">[Model from which to gather data]</field>
+        <field name="arch" type="[Type of data architecture]">
+            <list string="Estates">
+                <field string="[Column String Visible]" name="[Data name from Model]"/>
+            </list>
+        </field>
+    </record>
+-->


Delete unneeded comments please :)

msho-odoo · 2026-09-16T09:08:46Z

@@ -127,3 +127,4 @@ dmypy.json



ops, I shouldn't see this file here :)
environmental files like this one (or .vscode) for example shouldn't be pushed with your commit

msho-odoo · 2026-09-16T09:16:14Z

+    </record>
+
+    <!-- List View -->
+    <record id="estate_property_list" model="ir.ui.view">


Should be id="estate_property_view_list" according to coding guidelines
I am writing this to grab your attention to the existing of such guidelines, you can have a look there although you might come across some existing files in the codebase that are not following this comment for example (maybe they are old enough or the team is not strict on conventions) but you should always follow guidelines for new diffs in the code :)

Created offers Created tags

added computed field on offer validity added onchange on has_garden

Added the accept offer and refuse offer to offers

Delvaux-Jean-Baptiste added 2 commits September 15, 2026 10:42

[ADD] Add the basic setup for the estate module

63c3ad3

[IMP] estate: Added models

92218f6

msho-odoo marked this pull request as ready for review September 15, 2026 11:24

[FIX] Made field mandatory

2e76d0b

msho-odoo requested changes Sep 15, 2026

View reviewed changes

Delvaux-Jean-Baptiste added 2 commits September 15, 2026 14:10

[FIX] Styling issues

a2ee7f4

[ADD] estate: add estate access for base users

[FIX] formatting issues

2b37ba8

[ADD] estate: Added menus in app

52aac90

added fields and default values in fields of new estate [IMP] estate: updated gitignore to exclude vs config

[ADD] estate: Added garden area field

861aa17

[IMP] estate: Update List, Form and Search for cleaner display

msho-odoo requested changes Sep 16, 2026

View reviewed changes

Delvaux-Jean-Baptiste added 6 commits September 17, 2026 09:44

[IMP] estate: Added buyers, salespersons, tags and offers

6d3ba96

Created offers Created tags

[FIX] corrections of a couple of wrong names

fc7c422

[FIX] Added missing keys in manifest

dce0b63

[FIX] Removed unnecessary tracking in salesperson_id

0a6d7d5

[IMP] estate: added computed fields on total_area and best price

679e80d

added computed field on offer validity added onchange on has_garden

[IMP] estate: Added Cancel and Sold buttons to estate

85e2b75

Added the accept offer and refuse offer to offers

	<filter string="Available" name="available" domain="['\|',('state', '=', 'New'), ('state', '=', 'offer_received')]"></filter>
	<filter string="Available" name="available" domain="[('state', 'in', ('new', 'offer_received'))]"></filter>

Conversation

Delvaux-Jean-Baptiste commented Sep 15, 2026

Uh oh!

robodoo commented Sep 15, 2026

Uh oh!

msho-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msho-odoo commented Sep 15, 2026

Uh oh!

Delvaux-Jean-Baptiste commented Sep 15, 2026

Uh oh!

msho-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

msho-odoo left a comment •

edited

Loading