[ADD] : Creation of the new module by macai-odoo · Pull Request #1412 · odoo/tutorials

macai-odoo · 2026-09-15T09:11:08Z

Module creation as requested in the tutorial

robodoo · 2026-09-15T09:11:11Z

Relate to chapter 3 of the tutorial

Relate to chapter 4 of the tutorial

msho-odoo

Nice work 🔥

For the commit message we write in a way that aligns with when this commit is merged it will ..... and we add the name of the modules before the column :
so you might change it to something like [IMP] estate: add estate property model or however you like to describe your changes :)
refer to Git Guidlines
Also, left you some comments, thanks!

msho-odoo · 2026-09-15T12:45:24Z

@@ -0,0 +1 @@
+from . import estate_property


Always add a new line for end of files :)

msho-odoo · 2026-09-15T12:51:41Z

+    garden_orientation = fields.Selection(
+        string='Garden Orientation',
+        selection=[('North','North'),('South','South'),('East','East'),('West','West')]
+    )


The one line on the selection field is okay but when you have many values, it's better to have it like this.
Also, it's preferable to have the key as all small letters, so no confusion happens when they are used inside the code in if statements for example.

nitpick: some teams might stick to single quotes being only on technical strings (the ones that the user don't see) and double quotes are for the strings that the user can see)
so for example the selection can be ('east', "East") instead of ('east', 'East') but some teams don't do this, they just stick to their own convention which is all single quotes (if possible) or all double quotes
But I see you have all single quotes so good for me but thought to mention it so you know.

Suggested change

garden_orientation = fields.Selection(

string='Garden Orientation',

selection=[('North','North'),('South','South'),('East','East'),('West','West')]

)

garden_orientation = fields.Selection(

string='Garden Orientation',

selection=[

('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West')

]

)

msho-odoo · 2026-09-15T12:52:33Z

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_estate,estate,model_estate_property,base.group_user,1,1,1,1


EOF new line please for all files :)
Also alwyas refer to your runbot ci/style, if it's red, it will be telling you in the logs what's to fix :)

msho-odoo · 2026-09-15T13:00:28Z

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_estate,estate,model_estate_property,base.group_user,1,1,1,1


better to have it like this

Suggested change

access_estate,estate,model_estate_property,base.group_user,1,1,1,1

access_estate_property_user,access.estate.property,model_estate_property,base.group_user,1,1,1,1

The access_ thing is just a convention for this and I added _user at the end because this access rule is for the base user, you might have other rules on the same model but for _manager for example and son on.

msho-odoo · 2026-09-15T13:00:54Z

+    'name':'Real Estate',
+    'version':'1.0',
+    'depends':['base'],
+    'data':['security/ir.model.access.csv']


Suggested change

'data':['security/ir.model.access.csv']

'data': [

'security/ir.model.access.csv',

]

there is also a space after each column : :)

As mentioned in the chapter 5 of the training

Corrected the code based on the feedback from the PR (Thank you !)

msho-odoo · 2026-09-15T14:37:11Z

@macai-odoo please mention me here when you think the PR is ready for another review so I know, typically, after each chapter :)

Feature based on chapter 6 of the training

macai-odoo · 2026-09-16T07:35:37Z

Hello !
@msho-odoo I just finished the chapter 6 of the training !

Thank you !

Feature based on chapter 7 of the training

macai-odoo · 2026-09-16T09:59:41Z

This is the chapter 7 of the training with the implementation of :

Property Type
Property Tags
Property Offers

msho-odoo

Thanks for the nice work and for the green ci/style on runbot :)
Have a look a the warning in ci/tutorials and see how to get rid of them, it's stated in the logs there.

Left you some comments :)
Remember to ping again when ready for review, Thanks!

msho-odoo · 2026-09-16T09:52:47Z

+    name = fields.Char('Name', required=True)
+    description = fields.Text('Description')
+    postcode = fields.Char('Postcode', required=True)
+    date_availability = fields.Date('Availability', copy=False, default=fields.Date.add(fields.Date.today(), months=3))


For the default in this case the date will be valuated when first imported only, you need to call a function for the default here, check lambda on the code base and see how it's used in the default of the fields and use it here :)

msho-odoo · 2026-09-16T09:55:06Z

+        selection=[('north', 'North'),
+                   ('south', 'South'),
+                   ('east', 'East'),
+                   ('west', 'West')]


Suggested change

selection=[('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West')]

selection=[

('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West'),

]

msho-odoo · 2026-09-16T09:55:31Z

+        selection=[('new', 'New'),
+                   ('offer_received', 'Offer Received'),
+                   ('offer_accepted', 'Offer accepted'),
+                   ('sold', 'Sold'),
+                   ('cancelled', 'Cancelled')],


same styling as previous selection field :)

msho-odoo · 2026-09-16T09:56:09Z

+<?xml version="1.0"?>
+<odoo>
+    <menuitem id="test_menu_root" name="Real Estate">
+        <menuitem id="test_first_level_menu" name="Advertisements">


ids should be a bit more descriptive than that so other developers know mostly what it does from the name :)

msho-odoo · 2026-09-16T10:00:07Z

+                            <group>
+                                <field name="description" string="Description"/>
+                            </group>
+                            <group>
+                                <field name="bedrooms" string="Bedrooms"/>
+                            </group>
+                            <group>
+                                <field name="living_area" string="Living Area (sqm)"/>
+                            </group>


hmmm I think you don't need to add each field to a <group> tag, you do this to style different groups of fields that you want to show together, feel free to have a look at one of odoo's existing form view in any app and have a look at it's form xml record to see it better.

msho-odoo · 2026-09-16T10:01:51Z

+                                <field name="living_area" string="Living Area (sqm)"/>
+                            </group>
+                            <group>
+                                <field name="facades" string="Facades"/>


it's totally correct to have string attribute on the field in the xml view but you can have it on the field definition on the python model and don't use it here so you don't have to add the string attribute every time you use it in a view (unless you want to show it differently in certain views)

msho-odoo · 2026-09-16T10:02:50Z

+    bedrooms = fields.Integer('Bedrooms', default=2)
+    living_area = fields.Integer('Living Area')
+    facades = fields.Integer('Facades')
+    garage = fields.Boolean('Garage')


It's better practice to have boolean fields as is_something or has_something, so you may rename the fields to has_garden and has_garage

msho-odoo · 2026-09-16T10:05:59Z

+                <filter string="Available" name="active" domain="['|', ('state', '=', 'new'),
+                                                                        ('state', '=', 'offer_received')]"/>


Stick to the correct convention you were following name attribute before string attribute :)
Also, the domain like this is more readable (yours is still correct)

Suggested change

<filter string="Available" name="active" domain="['|', ('state', '=', 'new'),

('state', '=', 'offer_received')]"/>

<filter name="active" string="Available" domain="[('state', 'in', ('new', 'offer_received'))]"/>

msho-odoo · 2026-09-16T10:06:42Z

+    'data': [
+        'security/ir.model.access.csv',
+        'views/estate_property_views.xml',
+        'views/estate_menu.xml',
+            ]


Suggested change

'data': [

'security/ir.model.access.csv',

'views/estate_property_views.xml',

'views/estate_menu.xml',

]

'data': [

'security/ir.model.access.csv',

'views/estate_property_views.xml',

'views/estate_menu.xml',

]

Change style Change filter to match convention (estate_property_views.xml) rename boolean variable remove <group> block around each <field> for (estate_property_views.xml) change id for menuitem (estate_menu.xml) added lamba for the default for date_availability added author & license key in manifest

As refer in the chapter 8 of the training

macai-odoo · 2026-09-17T07:29:26Z

@msho-odoo Hello !
I've completed the chapter 8, thank you in advance for your feedback !

I also have a small question regarding the compute field.
In most of the exemple, they used a for each loop on self, is it mandatory to do so ?
(Got the answer in chapter 9 :) )
Thanks !

Remove unused import Move the comment at the end of lines

Added buttons to cancel or 'sell' a property Added buttons to refuse or accept an offer Set the buyer and the price on acceptance Refer to chapter 9 of the training

Added constraint on prices for property Added constraint on price for property_offer Refer to chapter 10 of the training

aboo-odoo · 2026-09-17T12:56:32Z

Hey I'll be managing your review now to spread the load among the 4 of us 😄

I also have a small question regarding the compute field. In most of the exemple, they used a for each loop on self, is it mandatory to do so ?

Glad you got the answer 👍 Indeed, self is a recordset, i.e. a group of one or more records (several estate properties for example). Due to ORM optimizations, we try to manage recordset as much as possible instead of managing individual records independently.

[ADD] : Creation of the new module

b41bda0

Module creation as requested in the tutorial

macai-odoo added 2 commits September 15, 2026 11:56

[IMP] : Creation of new model property

a6b3d75

Relate to chapter 3 of the tutorial

[IMP] : Added right for group_user

feee2db

Relate to chapter 4 of the tutorial

msho-odoo requested changes Sep 15, 2026

View reviewed changes

macai-odoo added 2 commits September 15, 2026 15:13

[IMP] : Added views into the app

e637945

As mentioned in the chapter 5 of the training

[FIX] estate: feedback implementation for git

c6c24d0

Corrected the code based on the feedback from the PR (Thank you !)

macai-odoo added 2 commits September 15, 2026 16:44

[IMP] estate: add title to list view

84e3360

Feature based on chapter 6 of the training

[IMP] estate: add search view

e5f83fc

Feature based on chapter 6 of the training

[IMP] estate: added tag,offer,property type

de60fce

Feature based on chapter 7 of the training

msho-odoo requested changes Sep 16, 2026

View reviewed changes

macai-odoo added 3 commits September 16, 2026 13:08

[IMP] estate: Add computation field for offer

d833304

As refer in the chapter 8 of the training

[IMP] estate: Add changing has_garden computation

c1ed077

As refer in the chapter 8 of the training

macai-odoo added 4 commits September 17, 2026 09:32

[FIX] estate: fix the styling

b297326

Remove unused import Move the comment at the end of lines

[FIX] estate: fix the comment styling

98ae518

[IMP] estate: Add buttons to update property

170e216

Added buttons to cancel or 'sell' a property Added buttons to refuse or accept an offer Set the buyer and the price on acceptance Refer to chapter 9 of the training

[IMP] estate: Add constraints for property and offer

5cf1031

Added constraint on prices for property Added constraint on price for property_offer Refer to chapter 10 of the training

aboo-odoo self-requested a review September 17, 2026 12:49

		@@ -0,0 +1 @@
		from . import estate_property No newline at end of file

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		access_estate,estate,model_estate_property,base.group_user,1,1,1,1 No newline at end of file

	access_estate,estate,model_estate_property,base.group_user,1,1,1,1
	access_estate_property_user,access.estate.property,model_estate_property,base.group_user,1,1,1,1

		<filter string="Available" name="active" domain="['\|', ('state', '=', 'new'),
		('state', '=', 'offer_received')]"/>

	<filter string="Available" name="active" domain="['\|', ('state', '=', 'new'),
	('state', '=', 'offer_received')]"/>
	<filter name="active" string="Available" domain="[('state', 'in', ('new', 'offer_received'))]"/>

Conversation

macai-odoo commented Sep 15, 2026

Uh oh!

robodoo commented Sep 15, 2026

Uh oh!

msho-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msho-odoo commented Sep 15, 2026

Uh oh!

macai-odoo commented Sep 16, 2026

Uh oh!

macai-odoo commented Sep 16, 2026

Uh oh!

msho-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

macai-odoo commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aboo-odoo commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

macai-odoo commented Sep 17, 2026 •

edited

Loading