Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from="ble"instead offrom="usb"Why
The Android robot app initialized its BLE manager twice, selected any writable/notifiable characteristic exposed by a peripheral, and treated a physical BLE connection as immediately writable. This could replace connection state during startup, select characteristics outside the OpenBot UART service, or dereference missing characteristics before service and notification setup completed.
This is the transport-only follow-up requested in #523. It does not include cart-following code, custom firmware support, write queuing, reconnect behavior, or developer notes.
Tests
./gradlew :robot:testDebugUnitTest(11 tests, including 6 new BLE regression tests)./gradlew :robot:assembleDebuggoogle-java-formatcheck on all four changed Java filesThe build emits the existing Android Gradle Plugin/compileSdk and D8 navigation warnings; both tasks complete successfully.