chore(ci): pin framework to the inventory completeness check - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5b4cc46d703381d76ffbcecbb282d1302a9fbf27to73b86e869fe4e1c61dd1e83ebc52d6adbc50f33fand updates the detector comments.Apply and inventory behavior
Merging this PR runs a real
terraform applybecause the workflow runs apply on a push tomain. No resource change is expected: #100 is CI-only, #101 only renames Terraform files, and #102 adds searches, an advisory check, and detector-only classification without changing resource configuration. The PR-head resource plan must nevertheless be reviewed before merge.Live inventory results first become observable in the post-merge detector. If it reports
INVENTORY / enumeration-unverified, that is the fail-closed token-permission/secret-readiness case: hand it to the owner rather than changing the framework.Merge ordering
#71 must merge before #72. After #71 merges, update #72 onto the resulting current
main, resolve the sharedrequired_checksoverlap while retaining both of #72's required-check entries, and require a fresh successful PR-headdeployplan and all checks at that updated head. F3a can be serialized before #71, between #71 and #72, or after #72; after any preceding merge, update every remaining candidate onto currentmainand require a fresh PR-head plan.Rollback
Revert this change as one unit so all four literals return to
5b4cc46d703381d76ffbcecbb282d1302a9fbf27and both comments are restored together. This stops inventory reporting; close any open inventory-only issue by hand. It does not undo applied changes, and none are expected.Acceptance evidence
Items 1–3 transcripts
PR-head run results (items 4–5)
Run: https://github.com/nwarila-platform/github-terraform-runner/actions/runs/35012737140
pull_request8e04c691f51e1823ea9dd8be5b7a9a0f2b587d9edeploy / Deploy:SUCCESSAuthenticated as assumedRoleId AROA3RQAW557VJBAJR2A6:GitHubActionsSanitized Terraform resource-plan rows:
updategithub_repository_ruleset.branch["<redacted>"]updateThis is one actionable resource row, so the expected no-actionable-row result was not met. It is an owner review finding to hand off before merge; no implementation change, retry, or additional push was made. No
check.inventory_completewarning is claimed from this PR-head log; live inventory classification first appears in the post-merge detector.Checks summary: every check at the exact head is complete.
deploy / DeployisSUCCESS;post_apply_detectorisSKIPPEDas event-gated forpull_request; there are no failing or pending checks.