chore(terraform): remove numeric file prefixes - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tffiles in the directory, so this is a semantic no-op; no executable HCL from the numbered source files changes, and the only removed placeholder HCL is the emptylocals {}block..gitignoreallowlist by replacing the numbered Terraform entries with the required plain-path entries and allowlisting the already trackedtools/test_detector_mode.py. This keeps intended deliverables visible to ordinary futuregit addoperations under ADR 0003.DESIGN.md: canonical deployment state uses the partial S3 backend, Terraform sensitivity markings do not encrypt or omit values from state, duplicated non-sensitive outputs remain displayable, and detector-mode local state is only a temporary exception.History
On
mainat the squash commit,git show --format= --name-status --find-renames=20% --break-rewrites=20% HEAD -- terraformrecords all six rename pairs; for a particular file,git log --find-renames=20% --break-rewrites=20% --name-status -- <old-path> <new-path>includes its numbered-path commits andgit blame -C -C -M -s -- <new-path>recovers surviving-line ancestry, while a one-new-pathgit logdoes not traverse a replaced placeholder and, on this commit,git log --followcrosses onlybackend.tfandproviders.tf, whose destinations were absent from the parent.Follow-on
The comment-only references to
30-locals.tfand11-variables.github.tfinnwarila-platform/github-terraform-runner/terraform/public/talos-cluster.yml:66,69remain an out-of-scope runner-repository follow-on.Complete acceptance transcripts (items 1–6)
Item 1 — authoritative Terraform diff
Result: PASS (exit 0).
Item 2 — declaration-header inventory
Result: PASS (exit 0; empty diff).
Item 3 — Terraform 1.15.4 and
make ciResult: PASS (exit 0).
Item 4 — explicit docs diff
Result: PASS (exit 0; no generated diff).
Item 5 — deny-all/index proofs and comment widths
Result: PASS (all exits 0; the three proofs were silent and all six widths matched).
Item 6 — clean status and commit-level rename records
Result: PASS (both exits 0; exactly the six required rename rows).